This repository was archived by the owner on May 29, 2026. It is now read-only.
feat(signing): adopt x-openregister-lifecycle on signingRequest#111
Closed
rubenvdlinde wants to merge 9 commits into
Closed
feat(signing): adopt x-openregister-lifecycle on signingRequest#111rubenvdlinde wants to merge 9 commits into
rubenvdlinde wants to merge 9 commits into
Conversation
- Extend base webpack config instead of replacing resolve/module - Add NodePolyfillPlugin for process polyfill compatibility - Add CnObjectSidebar + objectSidebarState for proper sidebar positioning - Follows ADR-017 (component composition) and ADR-018 (header actions)
- Fix Views.vue: remove <script setup>, fix merged template tags - Fix BatchAnonymizationView.vue: convert from <script setup> to Options API, fix escaped quotes - Fix EntityReviewTable.vue: fix escaped quotes throughout - Fix navigation.ts: merge duplicate interface property definitions - All files had corruption from bad code generation (merged lines, \x27 quotes)
Settings link in gear foldout now opens NcAppSettingsDialog modal
instead of routing to /settings page. Matches ADR-004 pattern:
- Admin config: /settings/admin/{appid} (NC admin panel)
- In-app settings: NcAppSettingsDialog modal from gear menu
- Wrap all strings in BatchAnonymizationView and EntityReviewTable - Wrap signing option labels and error fallbacks - Expand l10n files from 133 to 225 keys with Dutch translations
All translation keys now use sentence case per ADR-007. Only first word capitalized, except proper nouns and acronyms.
Replace docudesk's hand-written transition matrix with the platform's
declarative lifecycle annotation:
| Action | from | to |
|--------|------|----|
| send | DRAFT | PENDING |
| start | PENDING | IN_PROGRESS |
| complete | IN_PROGRESS | COMPLETED |
| decline | IN_PROGRESS | DECLINED |
| expire | PENDING / IN_PROGRESS | EXPIRED |
| cancel | DRAFT / PENDING / IN_PROGRESS | CANCELLED |
### Deletes
- SigningService::STATUS_TRANSITIONS constant table
- SigningService::isValidTransition method
- Explicit isValidTransition call in SigningService::cancelRequest
### Replaces with
- OpenRegister's LifecycleValidationListener (subscribes to ObjectUpdatingEvent
via StoppableEventInterface) rejects any save attempt that moves status
outside the schema's declared transitions.
Verified end-to-end against /apps/openregister/api/objects/{id}/transition:
- DRAFT → PENDING (send) → IN_PROGRESS (start) → COMPLETED (complete)
- send from COMPLETED correctly rejected with structured 422
…ative-annotation-pilot # Conflicts: # js/docudesk-dashboard.js # js/docudesk-dashboard.js.LICENSE.txt # js/docudesk-dashboard.js.map # js/docudesk-main.js # js/docudesk-main.js.LICENSE.txt # js/docudesk-main.js.map # js/docudesk-settings.js # js/docudesk-settings.js.LICENSE.txt # js/docudesk-settings.js.map # l10n/en.js # l10n/en.json # l10n/nl.js # l10n/nl.json # src/navigation/MainMenu.vue # src/store/modules/navigation.ts # src/views/Views.vue # src/views/anonymization/BatchAnonymizationView.vue # src/views/anonymization/EntityReviewTable.vue # src/views/signing/SigningRequestForm.vue # webpack.config.js
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/docudesk @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 108/108 | |||
| npm | ✅ | ✅ 529/529 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Coverage: 0% (0/10 statements)
Quality workflow — 2026-05-19 03:53 UTC
Download the full PDF report from the workflow artifacts.
Contributor
Author
|
Closing in prep for docudesk's manifest-system refactor (Tier-4 adoption) on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates signingRequest off STATUS_TRANSITIONS onto OpenRegister's lifecycle annotation. Six transitions. Net -36/+23 lines. Verified end-to-end. Companion: ConductionNL/openregister#1357