-
-
Notifications
You must be signed in to change notification settings - Fork 500
London | 26-ITP-May | Jorvan White | Sprint 1 | Form-Controls #1265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
JorvanW
wants to merge
12
commits into
CodeYourFuture:main
Choose a base branch
from
JorvanW:updated
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+73
−27
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a11a51e
Add files via upload
JorvanW 64a6300
Updated index.html file to match the form.html file and added my name…
4fea05a
removed non-sementic tags and added more labels and ids to the form c…
f5922f6
Removed Form-Controls/Forms.html
61ea410
Added lable names for each imput field
2918f50
Removed style tags from index.html and added link to style.css.
fc72ea8
Made updated to the readme.file
b163df1
Merge branch 'CodeYourFuture:main' into updated
JorvanW ea8f171
Merge branch 'updated' of https://github.com/JorvanW/Module-Onboardin…
c285463
Added <required> attribute to form inputs in index.html
a4c76c0
Added a new label imnput to only accept a first and last name and add…
1149e07
Added a new section on form controls to the index.
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| body { | ||
| font-family: Helvetica; | ||
| font-size: 30px; | ||
| } | ||
| form { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 10px; | ||
| } | ||
| input, select { | ||
| font-size: 25px; | ||
| } | ||
| button { | ||
| font-size: 25px; | ||
| width: 90px; | ||
| } | ||
| #name { | ||
| width: 500px; | ||
| } | ||
| #email { | ||
| width: 500px; | ||
| } | ||
| #submit { | ||
| width: 150px; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see 2 errors in the w3 validator https://validator.w3.org/nu/#textarea
The first child option element of a select element with a required attribute, and without a multiple attribute, and without a size attribute whose value is greater than 1, must have either an empty value attribute, or must have no text content. Consider either adding a placeholder option label, or adding a size attribute with a value equal to the number of option elements.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added a "select a size/colour" tag and made it required to not continue without selecting