London | 26-ITP-May | Jorvan White | Sprint 1 | Form-Controls #1265
London | 26-ITP-May | Jorvan White | Sprint 1 | Form-Controls #1265JorvanW wants to merge 11 commits into
Conversation
Created via VSC
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
JorvanW
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
JorvanW
added
the
Needs Review
Luro91
added
the
Review in progress
There was a problem hiding this comment.
Why did you create a new file and not use the index.html?
There was a problem hiding this comment.
Hello, I have resolved the issues and removed the new file and updated the index.html file
| font-size: 20px; | ||
| width: 100px; | ||
| } | ||
| </style> |
There was a problem hiding this comment.
How can you ensure clear separation of styling and html elements?
There was a problem hiding this comment.
I have now added a separate style.css file and removed the style tags from the index.html
| <input> | ||
| </div> | ||
| <div> | ||
| <label>Email</label> | ||
| <input> | ||
| </div> | ||
| <div> | ||
| <label>Size | ||
| <select> | ||
| <option value="xsmall">XS</option> | ||
| <option value="small">S</option> | ||
| <option value="medium">M</option> | ||
| <option value="large">L</option> | ||
| <option value="xlarge">XL</option> | ||
| <option value="xxlarge">XXL</option> | ||
| </select> | ||
| </label> | ||
| </div> | ||
| <div> | ||
| <label>Colour | ||
| <select> | ||
| <option value="yellow">Yellow</option> | ||
| <option value="black">Black</option> | ||
| <option value="pink">Pink</option> | ||
| </select> |
There was a problem hiding this comment.
What are the requirements of the form inputs?
Luro91
added
Reviewed
cjyuan
removed
the
Needs Review
…ontrols for better accessibility and styling.
JorvanW
added
the
Needs Review
Luro91
left a comment
Luro91
left a comment
There was a problem hiding this comment.
How can you ensure a lighthouse score of 100 for SEO?
What are the requirements for the email adress and name?
Luro91
removed
the
Needs Review
Added <meta name="description" content="T-Shirts form" /> to index.html
|
I have added, attributes to the "email" and "name" inputs and added a <meta name="description" content=> tag |
JorvanW
added
Needs Review
| <form> | ||
| <label for="name">Name</label> | ||
| <input id="name" type="text"/> | ||
| <input id="name" type="text" required/> |
There was a problem hiding this comment.
The name should be at least 2 characters
What is the customer's name? I must collect this data and ensure it contains at least two non-space characters.
| <input id="email" type="email" required/> | ||
| <label for="size">Size | ||
| <select id="size" required> | ||
| <option value="xsmall">XS</option> |
There was a problem hiding this comment.
I see 2 errors in the w3 validator https://validator.w3.org/nu/#textarea
The first child option element of a select element with a required attribute, and without a multiple attribute, and without a size attribute whose value is greater than 1, must have either an empty value attribute, or must have no text content. Consider either adding a placeholder option label, or adding a size attribute with a value equal to the number of option elements.
Luro91
added
Reviewed
…ed a title to explain the requirement if failed
3 participants
Created via VSC
Learners, PR Template
Self checklist
Changelist
Ticked off all checklist