Skip to content

Fix Double Sliders on Manage Protected Zones Interface [SYNTH-164] - #1396

Merged
PepperLola merged 2 commits into
devfrom
roushils/164/double-slider-fix
Jul 9, 2026
Merged

Fix Double Sliders on Manage Protected Zones Interface [SYNTH-164]#1396
PepperLola merged 2 commits into
devfrom
roushils/164/double-slider-fix

Conversation

@RoushilS

@RoushilS RoushilS commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Task

SYNTH-164

Symptom

When opening Protected Zones in the configure assets panel , there is a scrollbar covering the panel and one covering just the Manage Protected Zones Interface.

Solution

Removed the extra inner scroll container, so the protected zones screen no longer creates a nested scrolbar

Verification

  • Verify that there is only one scrollbar when opening the protected zones interface
  • All other functionality remains the same

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@RoushilS
RoushilS marked this pull request as ready for review July 9, 2026 17:14
@RoushilS
RoushilS requested review from a team as code owners July 9, 2026 17:14
@RoushilS RoushilS self-assigned this Jul 9, 2026

@rutmanz rutmanz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexD717 AlexD717 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PepperLola
PepperLola enabled auto-merge (squash) July 9, 2026 22:32
@PepperLola
PepperLola merged commit c0163e1 into dev Jul 9, 2026
16 checks passed
@PepperLola
PepperLola deleted the roushils/164/double-slider-fix branch July 9, 2026 22:33
BrandonPacewic added a commit that referenced this pull request Jul 13, 2026
* 'dev' of github.com:Autodesk/synthesis: (61 commits)
  update in more places
  Make Zone Config Panel Pretty `[SYNTH-225]` (#1402)
  Fix Mirabuf Loader Tests
  Merge Assetpack Properly
  fix: re-render scoring zones after resetting preferences
  Fix Double Sliders on Manage Protected Zones Interface `[SYNTH-164]` (#1396)
  format
  move divider
  revert to dim green
  InputSchemeSelection: SchemeSelector: call useStateContext
  InputSchemeSelection: extract SchemeSelector component
  format
  LabelWithTooltip: handle props correctly
  InputSchemeSelection: SchemeSelector: handle props correctly
  remove unneeded block
  simplify jsx ternary
  StyledComponents: take props correctly
  don't call react components directly
  Switch All Icons to SynthesisIcon `[SYNTH-202]` (#1387)
  Update GH Action Versions `[SYNTH-108]` (#1389)
  ...
BrandonPacewic added a commit that referenced this pull request Jul 14, 2026
* 'dev' of github.com:Autodesk/synthesis: (96 commits)
  update in more places
  Make Zone Config Panel Pretty `[SYNTH-225]` (#1402)
  Fix Mirabuf Loader Tests
  Merge Assetpack Properly
  fix: re-render scoring zones after resetting preferences
  Fix Double Sliders on Manage Protected Zones Interface `[SYNTH-164]` (#1396)
  format
  move divider
  revert to dim green
  InputSchemeSelection: SchemeSelector: call useStateContext
  InputSchemeSelection: extract SchemeSelector component
  format
  LabelWithTooltip: handle props correctly
  InputSchemeSelection: SchemeSelector: handle props correctly
  remove unneeded block
  simplify jsx ternary
  StyledComponents: take props correctly
  don't call react components directly
  Switch All Icons to SynthesisIcon `[SYNTH-202]` (#1387)
  Update GH Action Versions `[SYNTH-108]` (#1389)
  ...
BrandonPacewic added a commit that referenced this pull request Jul 14, 2026
…add-joints

* origin/dev: (72 commits)
  fix: `.npmrc` ignore
  fix: make assetpack tests actually fail on problems
  chore: move ignore to top level dir
  chore: global dot ignore
  fix: remove npmrc for github actions
  chore: fix ci failures
  feat: top level mira assembly urdf tagging
  update in more places
  Make Zone Config Panel Pretty `[SYNTH-225]` (#1402)
  Fix Mirabuf Loader Tests
  Merge Assetpack Properly
  feat: optimize obj parser
  fix: axis joints for wheel baised on urdf imports
  feat: add gltf parser
  fix: re-render scoring zones after resetting preferences
  Fix Double Sliders on Manage Protected Zones Interface `[SYNTH-164]` (#1396)
  format
  fix: refactor review comments & enable obj support
  move divider
  revert to dim green
  ...
@PepperLola PepperLola mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants