Skip to content

Auto-clean Autodesk Registry URLs [SYNTH-221] - #1392

Merged
PepperLola merged 1 commit into
devfrom
zachr/221/artifactory-evil
Jul 9, 2026
Merged

Auto-clean Autodesk Registry URLs [SYNTH-221]#1392
PepperLola merged 1 commit into
devfrom
zachr/221/artifactory-evil

Conversation

@rutmanz

@rutmanz rutmanz commented Jul 8, 2026

Copy link
Copy Markdown
Member

Task

SYNTH-221

Symptom

As bun does not support the omit-lockfile-registry-resolved npm option, and Autodesk requires the use of the internal artifactory registry, artifactory URLs will be committed to bun.lock when new packages are installed or the lockfile is otherwise regenerated. This breaks CI and is undesirable in a public repository.

Solution

Bun runs the postinstall script after packages are installed, which removes artifactory urls using regex. Note that I can't use standard commands like sed or > /dev/null and instead use npm packages to support non-unix systems

Verification

if you bun install <whatever> while using the Autodesk registry, the bun.lock file still has no artifactory urls. (Make sure to remove the package after)


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@rutmanz
rutmanz requested review from a team as code owners July 8, 2026 23:21
@rutmanz rutmanz changed the title feat: add post-install hook to clean artifactory urls from package lock Auto-clean Autodesk Registry URLs [SYNTH-221] Jul 8, 2026
@rutmanz
rutmanz force-pushed the zachr/221/artifactory-evil branch from 759f137 to b41320d Compare July 8, 2026 23:23

@azaleacolburn azaleacolburn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L.G.T.M - This is pretty L.I.V.E

@rutmanz
rutmanz requested a review from Dhruv-0-Arora July 9, 2026 18:35

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TWLQSAITILRFM

@AlexD717 AlexD717 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PepperLola
PepperLola merged commit f7280c7 into dev Jul 9, 2026
16 checks passed
@PepperLola
PepperLola deleted the zachr/221/artifactory-evil branch July 9, 2026 22:03
@PepperLola PepperLola mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants