Skip to content

Robots Float Downwards Within the Move Tool [SYNTH-173] - #1383

Merged
PepperLola merged 2 commits into
devfrom
alexey/173/fix-move-robot-float-downward
Jul 7, 2026
Merged

Robots Float Downwards Within the Move Tool [SYNTH-173]#1383
PepperLola merged 2 commits into
devfrom
alexey/173/fix-move-robot-float-downward

Conversation

@AlexD717

@AlexD717 AlexD717 commented Jul 7, 2026

Copy link
Copy Markdown
Member

Task

SYNTH-173

Symptom

Spawning a light robot and configuring it with swerve (arcade drive doesn't have this issue), then navigating to the move config tab causes it to slowly float down.

612770757-401e5ccb-4fd9-4719-b167-ad743bb42b03.mp4

Here is the light swerve robot tested with SDS_Tutorial_Bot_v4.zip

Solution

Physics wasn't being disabled on move configuration at a global level, and swerve was independently reactivating physics for each body fighting with the per body physics disabling, causing the robot to slowly drift down.

Disable physics at a global level when moving a robot. This is the same behavior done in the InitialConfig panel.

Verification

  • Light swerve robots no longer float down when using the move tool
  • Light swerve robots no longer float down when using the rotate tool

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@AlexD717 AlexD717 self-assigned this Jul 7, 2026
@AlexD717 AlexD717 added the bug Fixes an issue label Jul 7, 2026
@AlexD717
AlexD717 marked this pull request as ready for review July 7, 2026 17:04
@AlexD717
AlexD717 requested review from a team as code owners July 7, 2026 17:04

@RoushilS RoushilS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PepperLola
PepperLola enabled auto-merge (squash) July 7, 2026 21:22
@PepperLola
PepperLola merged commit 8f66792 into dev Jul 7, 2026
16 checks passed
@PepperLola
PepperLola deleted the alexey/173/fix-move-robot-float-downward branch July 7, 2026 21:24
BrandonPacewic added a commit that referenced this pull request Jul 9, 2026
* origin/branp/171/urdf-import-support: (37 commits)
  feat: missing material fallback
  fix: memory management stuff
  chore: update submodules
  chore: don't specify autodesk registry for jolt-physics
  chore: update joltjs
  Robots Float Downwards Within the Move Tool `[SYNTH-173]` (#1383)
  Remove TransformAssemblyPanel.tsx `[SYNTH-212]` (#1382)
  refactor: minor naming
  fix: lint
  refactor: move isWheel to separate file
  fix: axis alignment bug
  refactor: move other functions to `ConstraintSettingsUtilities.ts`
  refactor: move constraint functinos to separate file
  chore: some commenting and renaming
  refactor: ball constraints
  fix: hinge limits
  fix: slider constraints
  chore: cleanup imports
  refactor: standardize interface for applying limits
  chore: remove non-null asserts
  ...
@PepperLola PepperLola mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Fixes an issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants