Allow storing preferences in mirabuf files and refactor preferences system `[SYNTH-194]` and `[SYNTH-190]` by rutmanz · Pull Request #1371 · Autodesk/synthesis

rutmanz · 2026-07-01T18:13:20Z

Task

SYNTH-194
SYNTH-190
SYNTH-118

Symptom & Solution

For 194:

user preferences (not related to robot or field) are stored as top level keys and called global preferences. This is weird from a data structure perspective (especially bc we iterate over them), and this PR moves those to a "User" object
Remove motor preferences (they are unused)
Automatic migration of old preferences
Use mira hashes rather than model name as preference keys.

For 190:

Remove devtools panel (this was just used for exporting updated mira models, which is now in the configure panel)
Automatically migrate old stored metadata
Store all preferences (linked joints, drivetrain properties, etc) instead of just specific types so that one student can configure the robot and share it easily with all teammates.
Add metadata configuration page to allow students to rename assets. As we try more and more to de-emphasize the exporter, this will let them customize things

For 118:

Update all robot models to include sensible defaults

Verification

Run bun run assetpack to get the new models
Import an older dozer with configured stuff (Dozer v10 from the old assetpack) to check migration
Try making changes, exporting, and importing into a private window, see configuration still there
Make sure that user-modified preferences aren't overwritten

Before merging, ensure the following criteria are met:

All acceptance criteria outlined in the ticket are met.
Necessary test cases have been added and updated.
A feature toggle or safe disable path has been added (if applicable).
User-facing polish:
- Ask: "Is this ready-looking?"
Cross-linking between Jira and GitHub:
- PR links to the relevant Jira issue.
- Jira ticket has a comment referencing this PR.

…es as keys

rutmanz · 2026-07-02T20:11:23Z

I'm working on getting the checks to pass but this PR is ready for review

autodesk-chorus · 2026-07-02T20:13:37Z

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Trust Commitment requirement.

rutmanz · 2026-07-03T18:28:53Z

@azaleacolburn do you have any ideas for a long term solution to the autodesk registry getting added to the lockfile?

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Copilot

Pull request overview

Copilot reviewed 71 out of 71 changed files in this pull request and generated 13 comments.

azaleacolburn

I have a few suggestions, feel free to ignore :3

azaleacolburn · 2026-07-09T15:10:46Z

+            if (this.miraType === MiraType.FIELD && !PreferencesSystem.hasFieldPreferences(this.assemblyId)) {
+                this._fieldPreferences = defaultFieldPreferences()
+                editor.migrateDevtoolFieldData(this._fieldPreferences)
+                this._fieldPreferences = {
+                    ...this._fieldPreferences,
+                    ...editor.getUserData("synthesis:field_preferences"),
+                }
+            } else if (this.miraType === MiraType.ROBOT && !PreferencesSystem.hasRobotPreferences(this.assemblyId)) {
+                this._robotPreferences = defaultRobotPreferences()
+                editor.migrateDevtoolRobotData(this._robotPreferences)
+                this._robotPreferences = {
+                    ...this._robotPreferences,
+                    ...editor.getUserData("synthesis:robot_preferences"),
+                }
+            }


This is pedantic, but:

I think using the satisfies operator on every object literal would be a good practice.

This section is hard for me to read for some reason and I think some whitespace would be helpful, especially before the preferences objects get created.

Also, I don't like the amount of repeated structure within this function and within resetPreferences().

I could imagine a really cool solution where some function matches a set of functions, properties, and strings against an enum and then always runs the same structure of statements just with those variable arguments and functions. However, this would probably be unreadable.

If you have any (better) ideas about how to reduce repeated structure here, I would appreciate it.

I agree it could be better but the typing is really obnoxious and I would prefer to make that refactor a separate ticket if you think it's important

azaleacolburn

woaw

Dhruv-0-Arora

🔥

AlexD717

If I add a scoring/protected zone, then click reset (in the configure panel), it doesn't immediately remove that added zone until I either respawn the asset again or enter into the configuration menu.

The toast popup should either tell users they need to respawn it for changes to take effect, or it should immediately update.

AlexD717

lgtm

rutmanz added 11 commits June 30, 2026 14:50

refactor: migrate global preferences to user preferences and use hash…

e97b8b4

…es as keys

feat: update preferences loading system

ee97a0e

feat: add mira metadata loading

93e156d

Merge remote-tracking branch 'origin/dev' into zachr/190/mira-config

377d5b0

fix: make user preferences singular

3fa914c

fix: preference migration

88013b5

fix: make reset icon better

4e9c152

Merge remote-tracking branch 'origin/dev' into zachr/190/mira-config

9d8fed4

feat: update assetpack

a8c85c4

chore: run linter

9f63941

chore: update dozer references

5bee5e4

rutmanz force-pushed the zachr/190/mira-config branch from 6e3720b to 5bee5e4 Compare July 2, 2026 20:08

rutmanz self-assigned this Jul 2, 2026

rutmanz added ui/ux Relating to user interface, or in general, user experience mirabuf Relating to the mirabuf format refactor The most important part of software development. labels Jul 2, 2026

rutmanz marked this pull request as ready for review July 2, 2026 20:11

rutmanz requested review from a team as code owners July 2, 2026 20:11

rutmanz requested review from AlexD717, Dhruv-0-Arora and PepperLola July 2, 2026 20:11

Merge remote-tracking branch 'origin/dev' into zachr/190/mira-config

ab4a4bf

rutmanz force-pushed the zachr/190/mira-config branch from ebf382b to ab4a4bf Compare July 3, 2026 18:21

Merge remote-tracking branch 'origin/dev' into zachr/190/mira-config

eeb16d3

rutmanz commented Jul 3, 2026

View reviewed changes

rutmanz added 2 commits July 3, 2026 13:39

fix: revert bun.lock

1d810fa

fix: update tests

1227424

rutmanz requested a review from azaleacolburn July 8, 2026 15:47

fix: make default scene spawner work

e7aea7b

Dhruv-0-Arora requested changes Jul 8, 2026

View reviewed changes

Comment thread fission/src/systems/preferences/PreferencesSystem.ts Outdated

Dhruv-0-Arora reviewed Jul 8, 2026

View reviewed changes

Comment thread fission/src/mirabuf/MirabufSceneObject.ts Outdated

rutmanz mentioned this pull request Jul 8, 2026

Spawn Intake/Ejector in the middle of the robot [SYNTH-204] #1372

Open

7 tasks

fix: update snapshots and address Dhruv's feedback

3353ea7

rutmanz requested a review from Dhruv-0-Arora July 8, 2026 21:52

PepperLola requested a review from Copilot July 8, 2026 23:51

Copilot AI reviewed Jul 8, 2026

AlexD717 requested a review from Copilot July 8, 2026 23:52

Copilot started reviewing on behalf of AlexD717 July 8, 2026 23:53 View session

Copilot AI reviewed Jul 8, 2026

View reviewed changes

azaleacolburn requested changes Jul 9, 2026

View reviewed changes

feat: address copilot and Azalea feedback

96d5d38

rutmanz requested a review from azaleacolburn July 9, 2026 17:33

Merge remote-tracking branch 'origin/dev' into zachr/190/mira-config

930b6da

azaleacolburn approved these changes Jul 9, 2026

View reviewed changes

chore: run formatter

15a91a9

Dhruv-0-Arora approved these changes Jul 9, 2026

View reviewed changes

AlexD717 requested changes Jul 9, 2026

View reviewed changes

rutmanz mentioned this pull request Jul 9, 2026

URDF Import Support [SYNTH-171] #1363

Merged

5 tasks

rutmanz added 2 commits July 9, 2026 15:21

Merge remote-tracking branch 'origin/dev' into zachr/190/mira-config

977dc49

fix: re-render scoring zones after resetting preferences

76c8fcd

rutmanz requested a review from AlexD717 July 9, 2026 22:43

AlexD717 approved these changes Jul 9, 2026

View reviewed changes

Merge remote-tracking branch 'origin/dev' into zachr/190/mira-config

9f57b4c

PepperLola merged commit 58e0c2d into dev Jul 9, 2026
16 checks passed

PepperLola deleted the zachr/190/mira-config branch July 9, 2026 23:30

PepperLola mentioned this pull request Jul 16, 2026

v7.2.1 Release #1420

Merged

rutmanz mentioned this pull request Aug 5, 2026

use uuids for input schemes [SYNTH-251] #1423

Open

5 tasks

Uh oh!

Conversation

rutmanz commented Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task

Symptom & Solution

Verification

Uh oh!

rutmanz commented Jul 2, 2026

Uh oh!

autodesk-chorus Bot commented Jul 2, 2026

Uh oh!

rutmanz Jul 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azaleacolburn left a comment

Choose a reason for hiding this comment

Uh oh!

azaleacolburn Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

azaleacolburn Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

rutmanz Jul 9, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

azaleacolburn left a comment

Choose a reason for hiding this comment

Uh oh!

Dhruv-0-Arora left a comment

Choose a reason for hiding this comment

Uh oh!

AlexD717 left a comment • edited by rutmanz Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

AlexD717 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rutmanz commented Jul 1, 2026 •

edited

Loading

rutmanz Jul 3, 2026 •

edited

Loading

AlexD717 left a comment •

edited by rutmanz

Loading