Skip to content

remove unused GlobalUIComponent - #1357

Merged
PepperLola merged 3 commits into
devfrom
dionkud/remove-global-ui-component
Jun 29, 2026
Merged

remove unused GlobalUIComponent#1357
PepperLola merged 3 commits into
devfrom
dionkud/remove-global-ui-component

Conversation

@0xda157

@0xda157 0xda157 commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Task

Symptom

GlobalUIComponent contains no code other than return <></>

Solution

remove it

Verification

things seem to still be working


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@0xda157
0xda157 requested review from a team as code owners June 26, 2026 23:14

@PepperLola PepperLola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a comment in GlobalUIControls.ts referencing GlobalUIComponent.tsx that should probably be removed. The setting of the "global ui controls" that GlobalUIComponent does has been moved to MainHUD, so maybe it's worth moving the comment in GlobalUIComponent.tsx elsewhere? Or maybe it's self-explanatory enough that that's not needed.

@AlexD717 AlexD717 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Everything still works

@0xda157

0xda157 commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

There's a comment in GlobalUIControls.ts referencing GlobalUIComponent.tsx that should probably be removed. The setting of the "global ui controls" that GlobalUIComponent does has been moved to MainHUD, so maybe it's worth moving the comment in GlobalUIComponent.tsx elsewhere? Or maybe it's self-explanatory enough that that's not needed.

I think "This is where all the global references to the Global UI controls are located." should be sufficient

@0xda157
0xda157 requested a review from PepperLola June 29, 2026 16:08
@PepperLola
PepperLola enabled auto-merge June 29, 2026 16:51
@PepperLola
PepperLola merged commit 3fcde24 into dev Jun 29, 2026
16 checks passed
@PepperLola
PepperLola deleted the dionkud/remove-global-ui-component branch June 29, 2026 16:53
@PepperLola PepperLola mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants