Skip to content

ci(bun): migrating fission unit tests to bun [SYNTH-179] - #1355

Merged
PepperLola merged 3 commits into
devfrom
darora1/179/migrate-tests-bun
Jul 2, 2026
Merged

ci(bun): migrating fission unit tests to bun [SYNTH-179]#1355
PepperLola merged 3 commits into
devfrom
darora1/179/migrate-tests-bun

Conversation

@Dhruv-0-Arora

Copy link
Copy Markdown
Collaborator

Task

FissionUnitTest.yml is currently using npm and not bun.

SYNTH-179


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@Dhruv-0-Arora Dhruv-0-Arora self-assigned this Jun 26, 2026
@Dhruv-0-Arora
Dhruv-0-Arora force-pushed the darora1/179/migrate-tests-bun branch from 6ce6905 to 51f4394 Compare June 26, 2026 21:23
Comment thread .github/workflows/FissionUnitTest.yml
@Dhruv-0-Arora
Dhruv-0-Arora marked this pull request as ready for review June 30, 2026 19:47
@Dhruv-0-Arora
Dhruv-0-Arora requested review from a team as code owners June 30, 2026 19:47
@autodesk-chorus

Copy link
Copy Markdown

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Trust Commitment requirement.

@Dhruv-0-Arora

Copy link
Copy Markdown
Collaborator Author

I'm not sure where our consensus was on this PR. If we want to scrap it, then we should close this PR. Could be worth looking into though.

I believe the reason we use npm was because in deployments we use yarn/npm. @PepperLola knows why

@PepperLola PepperLola changed the title ci(bun): migrating fission unit tests to bun ci(bun): migrating fission unit tests to bun [SYNTH-179] Jun 30, 2026

@PepperLola PepperLola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the tests pass and we now use bun to build/deploy, I'm fine with moving the unit tests over to bun as well.

Comment thread .github/workflows/FissionUnitTest.yml Outdated
Signed-off-by: Dhruv Arora <dhruv.arora1@autodesk.com>
@Dhruv-0-Arora
Dhruv-0-Arora force-pushed the darora1/179/migrate-tests-bun branch from 4d34ad5 to 7003bab Compare July 1, 2026 00:08
@Dhruv-0-Arora
Dhruv-0-Arora requested review from 0xda157 and rutmanz July 1, 2026 00:19
@PepperLola
PepperLola merged commit 8672fbb into dev Jul 2, 2026
16 checks passed
@PepperLola
PepperLola deleted the darora1/179/migrate-tests-bun branch July 2, 2026 16:58
@PepperLola PepperLola mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants