Skip to content

Fix Toggle Button Sound Error [SYNTH-166] - #1349

Merged
PepperLola merged 2 commits into
devfrom
alexey/166/sound-error-fix
Jun 29, 2026
Merged

Fix Toggle Button Sound Error [SYNTH-166]#1349
PepperLola merged 2 commits into
devfrom
alexey/166/sound-error-fix

Conversation

@AlexD717

@AlexD717 AlexD717 commented Jun 25, 2026

Copy link
Copy Markdown
Member

Task

SYNTH-166

Symptom

When clicking between toggle button groups (ex, move/rotate in the configure panel) a error appears in the console related to the SoundPlayer.

Solution

The error was caused by trying to call pause() while a play() promise was still pending. While it was a harmless error (not affecting functionality), it was logging errors. Slightly refactored the code to allow the same sound to be played at the same time no longer requiring a call to pause().

Verification

  • Toggle button groups no longer cause errors in the console
  • Sound still plays as before

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@AlexD717 AlexD717 self-assigned this Jun 25, 2026
@AlexD717 AlexD717 added the sound label Jun 25, 2026
@AlexD717
AlexD717 marked this pull request as ready for review June 25, 2026 20:43
@AlexD717
AlexD717 requested review from a team as code owners June 25, 2026 20:43

@PepperLola PepperLola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@azaleacolburn azaleacolburn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PepperLola
PepperLola merged commit b001a54 into dev Jun 29, 2026
16 checks passed
@PepperLola
PepperLola deleted the alexey/166/sound-error-fix branch June 29, 2026 20:57
@PepperLola PepperLola mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants