Fix Toggle Button Sound Error [SYNTH-166] - #1349
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
SYNTH-166
Symptom
When clicking between toggle button groups (ex, move/rotate in the configure panel) a error appears in the console related to the SoundPlayer.
Solution
The error was caused by trying to call pause() while a play() promise was still pending. While it was a harmless error (not affecting functionality), it was logging errors. Slightly refactored the code to allow the same sound to be played at the same time no longer requiring a call to pause().
Verification
Before merging, ensure the following criteria are met: