APS Icon Fixes (Safer SVG Rendering)

[AlexD717]

Symptom

Logging in with APS caused some top bar icons to become invisible.

Solution

Reworked top bar icon rendering to keep inline SVG behavior while using a safer implementation:

• Removed dangerouslySetInnerHTML usage in TopBarIcons.tsx.
• Kept SVG inlining from local icon assets, but now parse SVG markup with DOMParser and append cloned SVG nodes.
• Preserved SVG ID scoping to avoid cross-icon ID collisions.

Verification

• Top bar icons render as inline SVG (not <img>).
• Multiple icon instances render correctly without collisions.
• Added targeted test coverage in src/test/ui/TopBarIcons.test.tsx.
• Logging in with APS causes no icons to disappear.

---

Before merging, ensure the following criteria are met:

• All acceptance criteria outlined in the ticket are met.
• Necessary test cases have been added and updated.
• A feature toggle or safe disable path has been added (if applicable).
• User-facing polish:
  • Ask: "Is this ready-looking?"
• Cross-linking between Jira and GitHub:
  • PR links to the relevant Jira issue.
  • Jira ticket has a comment referencing this PR.

[autodesk-chorus]

Chorus detected one or more security issues with this pull request. See the Checks tab for more details.

As a reminder, please follow the secure code review process as part of the Secure Coding Trust Commitment requirement.

[azaleacolburn]

I think we need to talk about these changes before merging, as the solution seems pretty scuffed and I don't fully believe everything Claude wrote in the TopBarIcons.tsx comment.

Also, the usage of dangerouslySetHtml is questionable, even though it doesn't use user input.

[Dhruv-0-Arora]

@copilot what are your thoughts on the changes made in TopBarIcons.tsx
Do you think that there is a better and safer way to implement that fix?

[Copilot]

@copilot what are your thoughts on the changes made in TopBarIcons.tsx
Do you think that there is a better and safer way to implement that fix?

Yes — I replaced the dangerouslySetInnerHTML approach with a safer DOMParser + cloned-<svg> rendering path in TopBarIcons.tsx (commit 1d3a51a). This keeps inline SVG behavior (so icons stay visible) while removing direct HTML injection. I also added focused tests in 9bb35b5 to verify inline SVG rendering and multi-instance behavior.

[Dhruv-0-Arora]

@AlexD717 could you take a look again and see if this still fixes it for you?

[AlexD717]

@Dhruv-0-Arora Yes, this also fixed it for me.