Proper Context Menu Panel Opening [SYNTH-47 & SYNTH-143] - #1335
Merged
Conversation
AlexD717
marked this pull request as ready for review
June 23, 2026 15:35
AlexD717
requested review from
0xda157,
BrandonPacewic,
PepperLola and
azaleacolburn
June 23, 2026 15:35
RoushilS
approved these changes
Jun 23, 2026
RoushilS
left a comment
RoushilS
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Definitely a much needed improvement.
Dhruv-0-Arora
approved these changes
Jun 23, 2026
Dhruv-0-Arora
left a comment
Dhruv-0-Arora
left a comment
Collaborator
There was a problem hiding this comment.
looks good. #1329 is waiting on this
The file upload handler is async (`await file.text()`), so state updates
from `setMatchModeConfigs` were not guaranteed to flush before the count
assertion. Moving the timeout inside `await act(async () => {...})` lets
React process all pending updates before the DOM is read.
BrandonPacewic
approved these changes
Jun 23, 2026
BrandonPacewic
force-pushed
the
alexey/143/move-selection-fix
branch
from
June 23, 2026 19:38
4c14584 to
3ddb861
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
SYNTH-47
SYNTH-143
Symptom
When right clicking on a robot and selecting either "move" or "configure" it opens the configure asset panel, but doesn't place you in the right section.
Solution
If you are trying to open a panel with parameters that is different from the current panel, we open it again with the right parameters.
Verification
Before merging, ensure the following criteria are met: