Skip to content

chore: apply more consistent formatting - #1334

Merged
PepperLola merged 2 commits into
devfrom
dionkud/formatting
Jun 24, 2026
Merged

chore: apply more consistent formatting#1334
PepperLola merged 2 commits into
devfrom
dionkud/formatting

Conversation

@0xda157

@0xda157 0xda157 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor
  • Add editorconfig so text editors consistently insert newlines etc
  • Apply biome formatting to all files in fission, not just fission/src

@0xda157
0xda157 requested review from a team as code owners June 22, 2026 22:22
Comment thread fission/biome.json
"formatWithErrors": false,
"indentStyle": "space",
"indentWidth": 4,
"lineEnding": "lf",

@0xda157 0xda157 Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that I'm remove these here because biome inherits them from the newly added editorconfig

@0xda157
0xda157 force-pushed the dionkud/formatting branch from ce15d46 to 14d64d0 Compare June 22, 2026 23:21
Comment thread fission/forge.config.ts Outdated
@0xda157
0xda157 force-pushed the dionkud/formatting branch from 14d64d0 to 8f2661c Compare June 22, 2026 23:49

@azaleacolburn azaleacolburn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Dhruv-0-Arora Dhruv-0-Arora changed the title chore: apply more consistant formatting chore: apply more consistent formatting Jun 24, 2026

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@AlexD717 AlexD717 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PepperLola
PepperLola enabled auto-merge June 24, 2026 23:30
@PepperLola
PepperLola merged commit 15a5195 into dev Jun 24, 2026
16 checks passed
@PepperLola
PepperLola deleted the dionkud/formatting branch June 24, 2026 23:30
@PepperLola PepperLola mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants