Migrate APS UserInfo API from v1 to v2 - #1330
Merged
Merged
Conversation
|
Chorus detected one or more security issues with this pull request. See the Checks tab for more details. As a reminder, please follow the secure code review process as part of the Secure Coding Trust Commitment requirement. |
Dhruv-0-Arora
left a comment
Dhruv-0-Arora
left a comment
Collaborator
There was a problem hiding this comment.
Is this PR ready for review? The playwright tests are currently failing as well as the Chorus security tests (which don't seem to be very important)
rutmanz
force-pushed
the
zachr/99/api-version-migration
branch
from
June 19, 2026 21:12
dc2b06f to
f60cd6e
Compare
RoushilS
approved these changes
Jun 19, 2026
PepperLola
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
SYNTH-99
Symptom
The old profile v1 api was being depricated and we needed to migrate to v2 for continued support
Solution
Followed migration guide and migrated to V2. I spent a long time trying to narrow the scopes (as
data:readis extremely permissive) but ended up realizing that the APS storage api calls requiredata:readanyway so we just have to live with powerful tokens.Verification
Can still log in and out, see photo, access assets in APS
Before merging, ensure the following criteria are met: