Skip to content

Drag Mode Collides with Scoring/Protected Zones [SYNTH-106] - #1310

Merged
PepperLola merged 5 commits into
devfrom
alexey/106/drag-mode-collision
Jun 17, 2026
Merged

Drag Mode Collides with Scoring/Protected Zones [SYNTH-106]#1310
PepperLola merged 5 commits into
devfrom
alexey/106/drag-mode-collision

Conversation

@AlexD717

@AlexD717 AlexD717 commented Jun 16, 2026

Copy link
Copy Markdown
Member

Task

SYNTH-106

Symptom

When trying to use drag mode on an object inside of a scoring or protected zone, the drag mode would not work.

Solution

Have the drag mode system ignore scoring/protected zones.

Verification

  • Spawn default assets
  • Drag robot and game piece into a scoring and protected zone
  • Verify that drag mode still works inside the zone
  • Verify that field objects still block drag mode
  • Verify that you can right click on robots/gameobjects inside scoring/protected zones

Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@AlexD717
AlexD717 marked this pull request as ready for review June 16, 2026 16:38
@AlexD717
AlexD717 requested review from a team as code owners June 16, 2026 16:38

@rutmanz rutmanz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Comment thread fission/src/systems/scene/DragModeSystem.ts
Comment thread fission/src/systems/scene/DragModeSystem.ts Outdated
@Dhruv-0-Arora

Copy link
Copy Markdown
Collaborator

An additional change that may be out of the scope of this PR is that this issue is actually persistent with right clicking assemblies -
Screenshot 2026-06-16 at 2 31 18 PM
Screenshot 2026-06-16 at 2 32 37 PM

I think we should have this fixed in this PR.

@AlexD717
AlexD717 requested a review from Dhruv-0-Arora June 16, 2026 22:31

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work

@Dhruv-0-Arora
Dhruv-0-Arora requested a review from rutmanz June 17, 2026 18:36
@Dhruv-0-Arora

Copy link
Copy Markdown
Collaborator

@rutmanz new changes

@PepperLola PepperLola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works, I can right click Dozer through a scoring zone

@PepperLola
PepperLola enabled auto-merge June 17, 2026 18:51
@PepperLola
PepperLola merged commit 45f3787 into dev Jun 17, 2026
16 checks passed
@PepperLola
PepperLola deleted the alexey/106/drag-mode-collision branch June 17, 2026 18:51
@PepperLola PepperLola mentioned this pull request Jul 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants