fix: [AARD-2113] Wiring Panel Styling Fixes - #1300
Conversation
PepperLola
left a comment
PepperLola
left a comment
There was a problem hiding this comment.
When I run the regular Java simulation sample and load Dozer, it doesn't immediately display the simulation inputs and outputs. I can refresh the Robot IO panel and that will sometimes make them load properly. Initially it took multiple refreshes to get it to work but I haven't been able to reproduce that since. The refresh/reset button at the top removes all the simulation inputs and outputs and makes another Robot IO panel refresh necessary.
When I add a junction node it shows no inputs or outputs until I refresh from the Robot IO panel.
HunterBarclay
changed the title
|
@PepperLola Odd. Java is borked on my laptop right now and I haven't been able to test fully with robot code yet. Let me know if you can see any issues appearing in the console. |
| const [nodes, setNodes, onNodesChange] = useNodesState([] as FlowNode[]) | ||
| const [edges, setEdges, onEdgesChange] = useEdgesState([] as FlowEdge[]) | ||
| const [_refreshHook, refreshGraph] = useReducer(x => !x, false) // Whenever I use reducers, it's always sketch. -Hunter | ||
| const [refreshHook, refreshGraph] = useReducer(x => !x, false) // Whenever I use reducers, it's always sketch. -Hunter |
There was a problem hiding this comment.
@PepperLola I've been using this as a janky way to refresh the graph. Probably need to re-evaluate.
05ae6d9 to
2722805
Compare
!: Auto Tester doesn't work and it appears the robot can't be controlled via robot code at the moment...
2722805 to
ef7f36f
Compare
PepperLola
left a comment
PepperLola
left a comment
There was a problem hiding this comment.
The wiring panel styles are fixed so I think it's good to merge. Code sim still doesn't work but that is going to be my next PR.
|
*cleansed the code |
Dhruv-0-Arora
left a comment
Dhruv-0-Arora
left a comment
There was a problem hiding this comment.
There is definitely room for UX improvement here such as tooltips and making the icons more clear (like the reset button I thought was a refresh button or something and the information icon gives me a full paragraph. Like I aint readin althat 🥀 )
The different zoom in and out views im not sure if they are even necessary tbh
I like how the wiring panel is saved through sessions of synthesis so if I refresh it is saved. However, I think that functionality should be for the simulation code itself because people might be spawning new iterations of robots and they won't want to redo their entire wiring panel each time they import a new iteration
also I was having some issue with dozer not changing its name to "Magic" but thats out of scope.
| @@ -1,4 +1,5 @@ | |||
| import { Grid, Stack } from "@mui/material" | |||
| import "@xyflow/react/dist/style.css" | |||
4 participants
Task
AARD-2113
Julian broke my wiring panel. I fix
Problem
Styling issues since UI refactor for the wiring panel.
Verification
Before merging, ensure the following criteria are met: