Skip to content

Bugfix/ld 19 rebased master - #30016

Closed
boa-pe wants to merge 2 commits into
ArduPilot:masterfrom
boa-pe:bugfix/ld_19_rebased_master
Closed

Bugfix/ld 19 rebased master#30016
boa-pe wants to merge 2 commits into
ArduPilot:masterfrom
boa-pe:bugfix/ld_19_rebased_master

Conversation

@boa-pe

@boa-pe boa-pe commented May 8, 2025

Copy link
Copy Markdown

LD06 / LD19 driver from 4.5.7 fixed with transplant from RPLidar.

  • Distance samples averaging
  • Ignoring measurements with low confidence

Fixed "old driver" with averaging and ignoring low confidence samples should improve sunlight resistance and general measurement stability. Still needs to be tested if that is the case and there is actual improvement against new driver merged in 4.6.0_beta2(?)

@peterbarker

Copy link
Copy Markdown
Contributor

Sadly, this is a significant step backwards in behaviour for me, master vs this PR.

In master I've got the sectors stable at appropriate distances for what the sensor is seeing. It all looks very nice.

In this PR the sectors still seem to get the correct maximum value, but the readings are unstable; the sectors are jumping between multiple different values on a sub-second (ie consecutive readings) time-frame.

I think that means there must be a logic issue here; if it was just average-vs-longest I would still expect to see stable values, just shorter than on current master?

I can create a pair of short videos to illustrate if that would help.

@boa-pe

boa-pe commented May 9, 2025

Copy link
Copy Markdown
Author

Hmm... As I remember that was behavior of old driver without this fix. Perhaps I missed something during rebase. I need to re-test this on hw.

@rmackay9

Copy link
Copy Markdown
Contributor

I've created another alternative solution here #30050. I haven't tested the code yet though :-)

@peterbarker

Copy link
Copy Markdown
Contributor

We have commits in master to fix the bright-light issues, and those will appear in 4.6.1.

Thanks for working through this with us!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants