AP_Camera: avoid SITL panic if pic taken with no pos estimate - #29558
Merged
Conversation
Co-authored-by: Daniel Ossig <ossig@tb-copters.de>
This was referenced Mar 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves issue #29530 by checking that the current_loc has been initialised before attempting to get the altitude from it.
This fix is thanks to @blaab2 and the commit is co-authored with him, thanks!
I've lightly tested this in SITL by performing a before/after test to confirm the issue occurs before this fix and does not afterwards.
BTW, the issue can be reproduced in SITL by doing this:
Below is a screenshot of what appears in the LOGS which is a mostly zero message
