Skip to content

[O2B-1318] Bugfix QC flag deletion - #1658

Merged
xsalonx merged 6 commits into
mainfrom
xsalonx/bugfix/qc-flag-delete
Jul 18, 2024
Merged

[O2B-1318] Bugfix QC flag deletion#1658
xsalonx merged 6 commits into
mainfrom
xsalonx/bugfix/qc-flag-delete

Conversation

@xsalonx

@xsalonx xsalonx commented Jul 16, 2024

Copy link
Copy Markdown
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • NA

Notable changes for developers:

Changes made to the database:

  • NA

@xsalonx xsalonx added bug Something isn't working backend labels Jul 16, 2024
@xsalonx xsalonx self-assigned this Jul 16, 2024
@xsalonx
xsalonx marked this pull request as ready for review July 16, 2024 09:35
@codecov

codecov Bot commented Jul 16, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.00%. Comparing base (1813df3) to head (3333cf1).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1658   +/-   ##
=======================================
  Coverage   44.00%   44.00%           
=======================================
  Files         872      872           
  Lines       14952    14952           
  Branches     2850     2850           
=======================================
  Hits         6580     6580           
  Misses       8372     8372           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xsalonx xsalonx changed the title Bugfix QC flag deletion [O2B-1318] Bugfix QC flag deletion Jul 16, 2024
Comment thread lib/server/services/qualityControlFlag/QcFlagService.js Outdated
@xsalonx
xsalonx requested a review from martinboulais July 17, 2024 13:33
@xsalonx
xsalonx merged commit 918b3ef into main Jul 18, 2024
@xsalonx
xsalonx deleted the xsalonx/bugfix/qc-flag-delete branch July 18, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backend bug Something isn't working

Development

Successfully merging this pull request may close these issues.

2 participants