Skip to content

[O2B-1306] Fix conditions for null timestamps in QC flag creation - #1638

Merged
xsalonx merged 66 commits into
mainfrom
xsalonx/bugfix/qc-flag-range-condition
Jul 9, 2024
Merged

[O2B-1306] Fix conditions for null timestamps in QC flag creation#1638
xsalonx merged 66 commits into
mainfrom
xsalonx/bugfix/qc-flag-range-condition

Conversation

@xsalonx

@xsalonx xsalonx commented Jul 2, 2024

Copy link
Copy Markdown
Collaborator

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • NA

Notable changes for developers:

  • Fixed bug with QC flag creation when run's timestamp is missing

Changes made to the database:

  • NA

@xsalonx xsalonx added the backend label Jul 2, 2024
@xsalonx xsalonx self-assigned this Jul 2, 2024
@codecov

codecov Bot commented Jul 3, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 76.19048% with 20 lines in your changes missing coverage. Please review.

Project coverage is 43.74%. Comparing base (a735ba4) to head (c7e20f8).

Files Patch % Lines
lib/public/views/QcFlags/format/formatQcFlagEnd.js 0.00% 7 Missing ⚠️
...b/public/views/QcFlags/format/formatQcFlagStart.js 0.00% 7 Missing ⚠️
lib/database/repositories/QcFlagRepository.js 80.95% 4 Missing ⚠️
...iews/QcFlags/ActiveColumns/qcFlagsActiveColumns.js 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1638      +/-   ##
==========================================
+ Coverage   43.66%   43.74%   +0.07%     
==========================================
  Files         867      869       +2     
  Lines       14844    14886      +42     
  Branches     2835     2846      +11     
==========================================
+ Hits         6482     6512      +30     
- Misses       8362     8374      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xsalonx
xsalonx marked this pull request as ready for review July 3, 2024 13:53
@xsalonx
xsalonx marked this pull request as draft July 3, 2024 14:24
@xsalonx
xsalonx force-pushed the xsalonx/bugfix/qc-flag-range-condition branch from 617f5e8 to f2f1c64 Compare July 4, 2024 09:56
@xsalonx
xsalonx marked this pull request as ready for review July 4, 2024 12:30
@xsalonx xsalonx changed the title Fix conditions for timestamps in QC flag creation [O2B-1306] Fix conditions for timestamps in QC flag creation Jul 4, 2024
@xsalonx xsalonx changed the title [O2B-1306] Fix conditions for timestamps in QC flag creation [O2B-1306] Fix conditions for null timestamps in QC flag creation Jul 4, 2024
Comment thread lib/server/services/qualityControlFlag/QcFlagService.js Outdated
Comment thread lib/server/services/qualityControlFlag/QcFlagService.js Outdated
Comment thread lib/database/migrations/20240528092020-add-qc-flag-origin-column copy.js Outdated
Comment thread lib/server/services/qualityControlFlag/QcFlagService.js
Comment thread lib/server/services/qualityControlFlag/QcFlagService.js Outdated
Comment thread lib/server/services/qualityControlFlag/QcFlagService.js Outdated
Comment thread lib/server/services/qualityControlFlag/QcFlagService.js Outdated
Comment thread lib/server/services/qualityControlFlag/QcFlagService.js Outdated
Comment thread lib/server/services/qualityControlFlag/QcFlagService.js Outdated
Comment thread test/lib/server/services/qualityControlFlag/QcFlagService.test.js Outdated
Comment thread lib/database/repositories/QcFlagEffectivePeriodRepository.js Outdated
Comment thread lib/public/views/QcFlags/format/formatQcFlagEnd.js
Comment thread lib/server/services/qualityControlFlag/QcFlagService.js Outdated
Comment thread lib/server/services/qualityControlFlag/QcFlagService.js
@xsalonx
xsalonx requested a review from martinboulais July 9, 2024 13:07
@xsalonx
xsalonx merged commit 42d4fb0 into main Jul 9, 2024
@xsalonx
xsalonx deleted the xsalonx/bugfix/qc-flag-range-condition branch July 9, 2024 13:54
@xsalonx xsalonx mentioned this pull request Jul 16, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

2 participants