Skip to content

update wolfSSL_get_SessionTicket to be able to return ticket length#9053

Merged
JacobBarthelmeh merged 3 commits intowolfSSL:masterfrom
rlm2002:sessionTickets
Aug 13, 2025
Merged

update wolfSSL_get_SessionTicket to be able to return ticket length#9053
JacobBarthelmeh merged 3 commits intowolfSSL:masterfrom
rlm2002:sessionTickets

Conversation

@rlm2002
Copy link
Copy Markdown
Contributor

@rlm2002 rlm2002 commented Jul 31, 2025

Description

Allow wolfSSL_get_SessionTicket() to retrieve the session ticket length if buffer is null but dataSz is not null. Used in JNI wrapper to adjust byte array size. This change does not modify the function signature.

zd#20208

Testing

./configure --enable-jni --enable-session-ticket

Checklist

  • added tests
  • updated/added doxygen
  • updated appropriate READMEs
  • Updated manual and documentation

@rlm2002
Copy link
Copy Markdown
Contributor Author

rlm2002 commented Aug 1, 2025

retest this please Jenkins. PRB-generic-config-parser: Found unhandled org.jenkinsci.plugins.workflow.support.steps.AgentOfflineException exception:
Unable to create live FilePath for wolf-linux-cloud-node-esf4hz; wolf-linux-cloud-node-esf4hz was marked offline: Connection was broken

@rlm2002 rlm2002 marked this pull request as ready for review August 1, 2025 17:08
@rlm2002 rlm2002 assigned wolfSSL-Bot and unassigned rlm2002 Aug 1, 2025
@devin-ai-integration
Copy link
Copy Markdown
Contributor

🛟 Devin Lifeguard found 1 likely issues in this PR

  • do-not-change-external-apis snippet: Create a new function such as wolfSSL_get_SessionTicket_ex(...) that supports the length-query behaviour, and let the original wolfSSL_get_SessionTicket retain its previous semantics (or call the new function while enforcing the old argument rules).

@rlm2002
please take a look at the above issues which Devin flagged. Devin will not fix these issues automatically.

@rlm2002 rlm2002 assigned rlm2002 and wolfSSL-Bot and unassigned wolfSSL-Bot and rlm2002 Aug 1, 2025
Copy link
Copy Markdown
Contributor

@JacobBarthelmeh JacobBarthelmeh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test case needs added for the new behavior.

doc/dox_comments/header_files/ssl.h needs updated for documenting the new behavior.

@rlm2002
Copy link
Copy Markdown
Contributor Author

rlm2002 commented Aug 4, 2025

retest this please jenkins: PRB-140-3-tests: Found unhandled hudson.remoting.RequestAbortedException exception:
java.io.StreamCorruptedException: invalid stream header: 636F7272

@rlm2002
Copy link
Copy Markdown
Contributor Author

rlm2002 commented Aug 4, 2025

Reworked JNI wrapper added in wolfSSLJNI PR 284, so this change is unnecessary. Closing this PR.

Reopened after wolfSSLJNI PR review.

Retest this please jenkins -
PRB-generic-config-parser: AgentOfflineException

@rlm2002 rlm2002 closed this Aug 4, 2025
@rlm2002 rlm2002 reopened this Aug 11, 2025
@rlm2002
Copy link
Copy Markdown
Contributor Author

rlm2002 commented Aug 12, 2025

retest this please jenkins: AgentOfflineException

@rlm2002
Copy link
Copy Markdown
Contributor Author

rlm2002 commented Aug 13, 2025

retest this please jenkins - AgentOfflineException

@JacobBarthelmeh JacobBarthelmeh merged commit 8458b5e into wolfSSL:master Aug 13, 2025
260 of 265 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants