20260409-IsValidFQDN#10183
Open
douzzer wants to merge 1 commit intowolfSSL:masterfrom
Open
Conversation
wolfSSL-Fenrir-bot
left a comment
wolfSSL-Fenrir-bot
left a comment
There was a problem hiding this comment.
Fenrir Automated Review — PR #10183
Scan targets checked: wolfssl-bugs, wolfssl-compliance, wolfssl-consttime, wolfssl-defaults, wolfssl-mutation, wolfssl-proptest, wolfssl-src, wolfssl-zeroize
Findings: 1
1 finding(s) posted as inline comments (see file-level comments below)
This review was generated automatically by Fenrir. Findings are non-blocking.
douzzer
force-pushed
the
20260409-IsValidFQDN
branch
2 times, most recently
from
dc4bd5d to
5b0f3ff
Compare
dgarske
reviewed
Apr 10, 2026
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
🐺 Skoll Code Review
Overall recommendation: APPROVE
Findings: 5 total — 5 posted, 0 skipped
Posted findings
- [Medium] Unsigned
nameSz <= 0comparison is tautologically equivalent to== 0—src/internal.c:13295 - [Low] Header comment says 'at least two labels' but code intentionally allows single labels —
src/internal.c:13281 - [Medium] Trailing dot stripped from
strbut not frompattern— asymmetric matching —src/internal.c:13380-13382 - [Medium] Underscore-containing DNS names lose case-insensitive matching —
src/internal.c:13371-13378 - [Medium] No unit tests for
IsValidFQDNor the newMatchDomainNameearly-return behavior —src/internal.c:13288-13345
Review generated by Skoll via openclaw
douzzer
force-pushed
the
20260409-IsValidFQDN
branch
from
5b0f3ff to
72a8adb
Compare
|
…idFQDN() tests/api/test_ossl_x509.c, tests/api/test_ossl_x509.h: add test_wolfssl_local_IsValidFQDN(). src/internal.c: in MatchDomainName(), when WOLFSSL_LEFT_MOST_WILDCARD_ONLY, do pattern matching and case folding only if target string validates as an FQDN.
douzzer
force-pushed
the
20260409-IsValidFQDN
branch
from
72a8adb to
6733e49
Compare
Contributor
Author
|
retest this please |
embhorn
approved these changes
Apr 28, 2026
Member
embhorn
left a comment
embhorn
left a comment
There was a problem hiding this comment.
Looks good. I have a PR draft that will build on this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/internal.c: addIsValidFQDN(), and inMatchDomainName(), do pattern matching and case folding only if target stringIsValidFQDN().tested with
see #10169 and ZD #21565