Skip to content

feat: count resolved incidents as acknowledged #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
benbridts wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: count resolved incidents as acknowledged #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions metrics_summary.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,6 +171,13 @@ func (m *MetricsCollectorSummary) collectIncidents(callback chan<- func()) {
}
}

// Some incidents might not get acknowledged but do get resolved, or get resolved before the acknowledgement
// In those cases we count the resolution as the acknowledgement.
if acknowledgedAt.After(resolvedAt) {
m.Logger().Debug("Overwriting acknowledgedAt based on resolvedAt", slog.String("incident", incident.ID), slog.Time("from", acknowledgedAt), slog.Time("to", resolvedAt))
acknowledgedAt = resolvedAt
}

incidentPriority := ""
if incident.Priority != nil {
incidentPriority = incident.Priority.Name
Expand Down