feat: count resolved incidents as acknowledged#61
Open
benbridts wants to merge 1 commit intowebdevops:mainfrom
Open
feat: count resolved incidents as acknowledged#61benbridts wants to merge 1 commit intowebdevops:mainfrom
benbridts wants to merge 1 commit intowebdevops:mainfrom
Conversation
this keeps MTTA metrics <= MTTR metrics
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



We were having issues where we saw the pagerduty_summary_incident_acknowledge_duration_sum constantly incease, even though there were no open incidents in pagerduty.
We realized this happend because an incident was resolved before it got acknowledged.
This PR makes it so that the acknowledge_duration is capped at the resolved_duration.
Tested locally:
Before
After