Skip to content

feat(fs): #3243 add encoding option to readTextFile functions #3244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amrbashir merged 3 commits into from
Feb 9, 2026
Merged

feat(fs): #3243 add encoding option to readTextFile functions #3244

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe56896
feat(fs): #3243 add encoding option to readFile and readTextFile func…
SeijiOkuda Feb 1, 2026
ef50d1a
feat(fs): add encoding option to ReadFileOptions and update readTextF…
SeijiOkuda Feb 2, 2026
5ad3d80
add change file
amrbashir Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/fs/api-iife.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 4 additions & 3 deletions plugins/fs/guest-js/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,7 +722,8 @@ async function readDir(
*/
interface ReadFileOptions {
/** Base directory for `path` */
baseDir?: BaseDirectory
baseDir?: BaseDirectory,
encoding?: string
Copy link
Copy Markdown
Member

@amrbashir amrbashir Feb 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing documentation

Copy link
Copy Markdown
Contributor Author

@SeijiOkuda SeijiOkuda Feb 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amrbashir
Thanks for the review!
Added documentation comments.

}

/**
Expand Down Expand Up @@ -753,7 +754,7 @@ async function readFile(
}

/**
* Reads and returns the entire contents of a file as UTF-8 string.
* Reads and returns the entire contents of a file as a string using the specified encoding (default: UTF-8).
* @example
* ```typescript
* import { readTextFile, BaseDirectory } from '@tauri-apps/plugin-fs';
Expand All @@ -777,7 +778,7 @@ async function readTextFile(

const bytes = arr instanceof ArrayBuffer ? arr : Uint8Array.from(arr)

return new TextDecoder().decode(bytes)
return new TextDecoder(options?.encoding ?? 'utf-8').decode(bytes)
}

/**
Expand Down
Loading