feat(fs): #3243 add encoding option to readTextFile functions#3244
feat(fs): #3243 add encoding option to readTextFile functions#3244amrbashir merged 3 commits intotauri-apps:v2from
Conversation
…tFile functions
Package Changes Through 5ad3d80There are 2 changes which include fs with minor, fs-js with minor Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
| /** Base directory for `path` */ | ||
| baseDir?: BaseDirectory | ||
| baseDir?: BaseDirectory, | ||
| encoding?: string |
There was a problem hiding this comment.
@amrbashir
Thanks for the review!
Added documentation comments.
…ileLines functions
@amrbashir |
|
plugins-workspace/plugins/fs/src/commands.rs Lines 1208 to 1227 in 05045f9 |
|
I think that could be fixed in another PR |
Summary
Added support for reading text files encoded in character sets other than UTF-8 (e.g. Shift_JIS).
Previously, the application assumed UTF-8 encoding, which caused garbled text in some cases. With this change, multiple character encodings are now supported and such files can be read correctly.
Closes #3243
Changes
Background / Motivation
Verification
Usage
You can specify the encoding when reading a text file: