-
-
Notifications
You must be signed in to change notification settings - Fork 635
Remove stale Coveralls integration #3204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 2 commits
71aeecf
7dee749
db6576a
6261c56
80c86a8
42d2e0c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| # TODO: This file is not used for CI | ||
| require "coveralls/rake/task" if ENV["USE_COVERALLS"] == "TRUE" | ||
|
|
||
| require "pathname" | ||
|
justin808 marked this conversation as resolved.
|
||
| require "active_support/core_ext/string" | ||
|
|
@@ -25,11 +24,9 @@ namespace :run_rspec do | |
|
|
||
| desc "(HACK) Run RSpec on spec/empty_spec in order to have SimpleCov generate a coverage report from cache" | ||
| task :empty do | ||
| sh %(#{ENV['USE_COVERALLS'] ? 'COVERAGE=true' : ''} rspec spec/empty_spec.rb) | ||
| sh "rspec spec/empty_spec.rb" | ||
|
coderabbitai[bot] marked this conversation as resolved.
Outdated
|
||
| end | ||
|
justin808 marked this conversation as resolved.
Outdated
|
||
|
|
||
| Coveralls::RakeTask.new if ENV["USE_COVERALLS"] == "TRUE" | ||
|
|
||
| desc "run all tests" | ||
| task run_rspec: %i[gem dummy empty js_tests] do | ||
| puts "Completed all RSpec tests" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good improvement — the task now skips cleanly instead of running a no-op spec. One edge case: |
||
|
|
@@ -71,7 +68,6 @@ def run_tests_in(dir, options = {}) | |
| command_name = options.fetch(:command_name, path.basename) | ||
| rspec_args = options.fetch(:rspec_args, "") | ||
| env_vars = +"#{options.fetch(:env_vars, '')} TEST_ENV_COMMAND_NAME=\"#{command_name}\"" | ||
| env_vars << "COVERAGE=true" if ENV["USE_COVERALLS"] | ||
| sh_in_dir(path.realpath, "#{env_vars} bundle exec rspec #{rspec_args}") | ||
| end | ||
|
|
||
|
|
||
Uh oh!
There was an error while loading. Please reload this page.