Remove stale Coveralls integration #3204
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -119,12 +119,6 @@ GEM | |
| coderay (1.1.3) | ||
| concurrent-ruby (1.3.6) | ||
| connection_pool (3.0.2) | ||
| crass (1.0.6) | ||
| csv (3.3.5) | ||
| cypress-on-rails (1.20.0) | ||
|
|
@@ -401,17 +395,11 @@ GEM | |
| uri (>= 0.12.0) | ||
| stringio (3.2.0) | ||
| strscan (3.1.0) | ||
| terminal-table (3.0.2) | ||
| unicode-display_width (>= 1.1.1, < 3) | ||
| thor (1.5.0) | ||
| tilt (2.3.0) | ||
| timeout (0.6.0) | ||
| tsort (0.2.0) | ||
| turbo-rails (2.0.20) | ||
| actionpack (>= 7.1.0) | ||
|
|
@@ -448,7 +436,6 @@ DEPENDENCIES | |
| bootsnap | ||
| capybara (~> 3.40) | ||
| capybara-screenshot | ||
| cypress-on-rails (~> 1.19) | ||
| debug | ||
| equivalent-xml | ||
|
|
@@ -481,6 +468,7 @@ DEPENDENCIES | |
| sdoc | ||
| selenium-webdriver (= 4.9.0) | ||
| shakapacker (= 9.6.1) | ||
| simplecov (~> 0.16.1) | ||
| spring (~> 4.0) | ||
| sprockets (~> 4.0) | ||
| sqlite3 (~> 1.6) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,12 +6,6 @@ | |
| tasks = %w[lint run_rspec] | ||
| prepare_for_ci = %w[node_package dummy_apps] | ||
|
|
||
| desc "Run all tests and linting" | ||
| task default: tasks | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -41,7 +41,7 @@ def add_test_related_gems_to_gemfile | |
| gem("rspec-rails", group: :test) | ||
| # NOTE: chromedriver-helper was deprecated in 2019. Modern selenium-webdriver (4.x) | ||
| # and GitHub Actions have built-in driver management, so no driver helper is needed. | ||
| gem("simplecov", require: false, group: :test) | ||
| end | ||
|
|
||
| def replace_prerender_if_server_rendering | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,5 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| require "pathname" | ||
| require "yaml" | ||
|
|
||
|
|
@@ -141,8 +139,6 @@ namespace :run_rspec do | |
| pinned_version_examples.each { |example_type| Rake::Task[example_type.rspec_task_name].invoke } | ||
| end | ||
|
|
||
| desc "run all tests no examples" | ||
| task all_but_examples: %i[gem dummy_no_turbolinks dummy js_tests] do | ||
| puts "Completed all RSpec tests" | ||
|
|
@@ -209,7 +205,6 @@ def run_tests_in(dir, options = {}) | |
| env_tokens = [] | ||
| env_tokens << options.fetch(:env_vars, "").strip unless options.fetch(:env_vars, "").strip.empty? | ||
| env_tokens << "TEST_ENV_COMMAND_NAME=\"#{command_name}\"" | ||
|
|
||
| env_vars = env_tokens.join(" ") | ||
| command = "#{env_vars} bundle exec rspec #{rspec_args}" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -213,7 +213,7 @@ namespace :shakapacker_examples do # rubocop:disable Metrics/BlockLength | |
| # Use unbundled_sh_in_dir to ensure the generator uses the example app's | ||
| # gem versions, not the parent workspace's cached bundle context. | ||
| unbundled_sh_in_dir(example_type.dir, generator_commands) | ||
| # Re-run bundle install since dev_tests generator adds rspec-rails and simplecov to Gemfile | ||
| bundle_install_in(example_type.dir) | ||
|
|
||
| # Apply specific React version for compatibility testing examples | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -115,12 +115,6 @@ GEM | |
| coderay (1.1.3) | ||
| concurrent-ruby (1.3.6) | ||
| connection_pool (3.0.2) | ||
| crass (1.0.6) | ||
| csv (3.3.5) | ||
| cypress-on-rails (1.19.0) | ||
|
|
@@ -391,16 +385,11 @@ GEM | |
| uri (>= 0.12.0) | ||
| stringio (3.2.0) | ||
| strscan (3.1.5) | ||
| terminal-table (3.0.2) | ||
| unicode-display_width (>= 1.1.1, < 3) | ||
| thor (1.5.0) | ||
| tilt (2.2.0) | ||
| timeout (0.4.3) | ||
| tsort (0.2.0) | ||
| turbo-rails (2.0.6) | ||
| actionpack (>= 6.0.0) | ||
|
|
@@ -439,7 +428,6 @@ DEPENDENCIES | |
| bootsnap | ||
| capybara (~> 3.40) | ||
| capybara-screenshot | ||
| cypress-on-rails (~> 1.19) | ||
| debug | ||
| equivalent-xml | ||
|
|
@@ -471,6 +459,7 @@ DEPENDENCIES | |
| sdoc | ||
| selenium-webdriver (= 4.9.0) | ||
| shakapacker (= 9.6.1) | ||
| simplecov (~> 0.16.1) | ||
| spring (~> 4.0) | ||
| sprockets (~> 4.0) | ||
| sqlite3 (~> 1.6) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,7 +49,7 @@ | |
| it "adds test-related gems to Gemfile" do | ||
| assert_file("Gemfile") do |contents| | ||
| expect(contents).to match("gem \"rspec-rails\", group: :test") | ||
| expect(contents).to match("gem \"simplecov\", require: false, group: :test") | ||
| # chromedriver-helper was removed as it's deprecated since 2019 | ||
| # Modern selenium-webdriver (4.x) handles driver management automatically | ||
| end | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -347,7 +347,7 @@ bundle exec rspec | |
|
|
||
| If you run `rspec` at the top level, you'll see this message: `require': cannot load such file -- rails_helper (LoadError)` | ||
|
|
||
| If you run tests with `COVERAGE=true`, you can view the SimpleCov report at `coverage/index.html`. | ||
|
|
||
| ### Debugging | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,33 +33,33 @@ gem "amazing_print" | |
|
|
||
| group :development do | ||
| # Access an interactive console on exception pages or by calling 'console' anywhere in the code. | ||
| gem "web-console" | ||
| gem "listen" | ||
| # Spring speeds up development by keeping your application running in the background. Read more: https://github.com/rails/spring | ||
| gem "spring" | ||
| gem "spring-watcher-listen" | ||
| end | ||
|
|
||
| group :development, :test do | ||
| gem "faker" | ||
| gem "graphiql-rails" | ||
| gem "pry", ">= 0.14.1" # Console with powerful introspection capabilities | ||
| # Need to use master of pry-byebug to use latest pry version | ||
| # Loaded manually in spec_helper.rb so specs can boot on readline-less Ruby builds. | ||
| gem "pry-byebug", github: "shakacode/pry-byebug", require: false # Integrates pry with byebug | ||
| gem "pry-doc" # Provide MRI Core documentation | ||
| gem "pry-rails" # Causes rails console to open pry. `DISABLE_PRY_RAILS=1 rails c` can still open with IRB | ||
| gem "pry-theme" # An easy way to customize Pry colors via theme files | ||
|
|
||
| gem "rbs", require: false | ||
| gem "scss_lint", require: false | ||
| gem "fakefs", require: "fakefs/safe" | ||
| end | ||
|
|
||
| group :test do | ||
| gem "capybara", ">= 3.38.0" | ||
| gem "capybara-screenshot" | ||
| gem "simplecov", "~> 0.16.1", require: false | ||
| gem "equivalent-xml" | ||
| gem "generator_spec" | ||
| gem "launchy" | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -149,12 +149,6 @@ GEM | |
| fiber-annotation | ||
| fiber-local (~> 1.1) | ||
| json | ||
| crack (1.0.0) | ||
| bigdecimal | ||
| rexml | ||
|
|
@@ -436,15 +430,9 @@ GEM | |
| sqlite3 (2.9.2-x86_64-darwin) | ||
| sqlite3 (2.9.2-x86_64-linux-gnu) | ||
| stringio (3.2.0) | ||
| thor (1.5.0) | ||
| tilt (2.4.0) | ||
| timeout (0.4.4) | ||
| traces (0.18.2) | ||
| tsort (0.2.0) | ||
| turbolinks (5.2.1) | ||
|
|
@@ -492,7 +480,6 @@ DEPENDENCIES | |
| capybara (>= 3.38.0) | ||
| capybara-screenshot | ||
| commonmarker | ||
| equivalent-xml | ||
| fakefs | ||
| faker | ||
|
|
@@ -527,6 +514,7 @@ DEPENDENCIES | |
| scss_lint | ||
| selenium-webdriver (= 4.9.0) | ||
| shakapacker (= 9.6.1) | ||
| simplecov (~> 0.16.1) | ||
| spring | ||
| spring-watcher-listen | ||
| sprockets | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,11 +3,6 @@ | |
| # Rake will automatically load any *.rake files inside of the "rakelib" folder | ||
| # See rakelib/ | ||
| tasks = %w[run_rspec lint] | ||
|
|
||
| desc "Run all tests and linting" | ||
| task default: tasks | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,6 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| # TODO: This file is not used for CI | ||
|
|
||
| require "pathname" | ||
|
justin808 marked this conversation as resolved.
|
||
| require "active_support/core_ext/string" | ||
|
|
@@ -23,13 +22,15 @@ namespace :run_rspec do | |
| run_tests_in(spec_dummy_dir) | ||
| end | ||
|
|
||
| desc "(HACK) Run RSpec on spec/empty_spec.rb — set COVERAGE=true to generate a SimpleCov report from cache" | ||
| task :empty do | ||
| if ENV["COVERAGE"] == "true" | ||
| sh "bundle exec rspec spec/empty_spec.rb" | ||
| else | ||
| puts "Skipping run_rspec:empty (set COVERAGE=true to generate a SimpleCov report from cache)" | ||
| end | ||
| end | ||
|
|
||
| desc "run all tests" | ||
| task run_rspec: %i[gem dummy empty js_tests] do | ||
| puts "Completed all RSpec tests" | ||
|
Contributor
There was a problem hiding this comment. Good improvement — the task now skips cleanly instead of running a no-op spec. One edge case: |
||
|
|
@@ -71,7 +72,6 @@ def run_tests_in(dir, options = {}) | |
| command_name = options.fetch(:command_name, path.basename) | ||
| rspec_args = options.fetch(:rspec_args, "") | ||
| env_vars = +"#{options.fetch(:env_vars, '')} TEST_ENV_COMMAND_NAME=\"#{command_name}\"" | ||
| sh_in_dir(path.realpath, "#{env_vars} bundle exec rspec #{rspec_args}") | ||
| end | ||
|
|
||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.