Update additional files to use CMake 3.28 instead of 3.31#900
Merged
mhucka merged 4 commits intoquantumlib:mainfrom Oct 21, 2025
Merged
Update additional files to use CMake 3.28 instead of 3.31#900mhucka merged 4 commits intoquantumlib:mainfrom
mhucka merged 4 commits intoquantumlib:mainfrom
Conversation
This matches the recent changes in other files to use cmake 3.28.
Some additional Python files need to be changed too.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mhucka
changed the title
mhucka
changed the title
mhucka
changed the title
fdmalone
approved these changes
Oct 21, 2025
Collaborator
fdmalone
left a comment
fdmalone
left a comment
There was a problem hiding this comment.
Why was it rolled back?
Collaborator
Author
Sergei noted in his recent big PR that the default version of cmake on Ubuntu Linux is currently 3.28. Originally, I thought there was something in version 3.31 that was needed, but after testing with 3.28, I couldn't find anything breaking or even warnings, so whatever it was, it doesn't seem to have been critical. (Some references to 3.31 in the qsim cmake files were already changed to 3.28, but I missed some others. This PR should catch the rest.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This matches the recent changes in other files to use cmake 3.28.