Skip to content

Commit beacb4f

Browse files
authored
Update additional files to use CMake 3.28 instead of 3.31 (#900)
This matches the recent changes in other files to use cmake 3.28.
1 parent f992060 commit beacb4f

4 files changed

Lines changed: 8 additions & 8 deletions

File tree

Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ RUN apt-get update && \
2727

2828
# Ubuntu 24's version of CMake is 3.28. We need a newer version.
2929
RUN apt-get remove --purge --auto-remove cmake
30-
RUN wget -q https://github.com/Kitware/CMake/releases/download/v3.31.7/cmake-3.31.7-linux-x86_64.sh && \
31-
sh cmake-3.31.7-linux-x86_64.sh --prefix=/usr/local --skip-license
30+
RUN wget -q https://github.com/Kitware/CMake/releases/download/v3.28.1/cmake-3.28.1-linux-x86_64.sh && \
31+
sh cmake-3.28.1-linux-x86_64.sh --prefix=/usr/local --skip-license
3232

3333
# Copy relevant files for simulation.
3434
COPY ./Makefile /qsim/Makefile

dev-requirements.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1+
cmake~=3.28.1
12
black~=25.9.0
2-
cmake~=3.31.0
33
flynt~=1.0
44
pytest
55
pytest-xdist

install/tests/Dockerfile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@ RUN apt-get update && \
2727

2828
# Ubuntu 24's version of CMake is 3.28. We need a newer version.
2929
RUN apt-get remove --purge --auto-remove cmake
30-
RUN wget -q https://github.com/Kitware/CMake/releases/download/v3.31.7/cmake-3.31.7-linux-x86_64.sh && \
31-
sh cmake-3.31.7-linux-x86_64.sh --prefix=/usr/local --skip-license
30+
RUN wget -q https://github.com/Kitware/CMake/releases/download/v3.28.1/cmake-3.28.1-linux-x86_64.sh && \
31+
sh cmake-3.28.1-linux-x86_64.sh --prefix=/usr/local --skip-license
3232

3333
# Copy qsim files from the outside-Docker location to an inside-Docker location.
3434
COPY ./ /qsim/

setup.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,8 @@ def run(self):
4747
cmake_version = parse(
4848
re.search(r"version\s*([\d.]+)", out.decode()).group(1)
4949
)
50-
if cmake_version < parse("3.31.0"):
51-
raise RuntimeError("CMake >= 3.31.0 is required on Windows")
50+
if cmake_version < parse("3.28.0"):
51+
raise RuntimeError("CMake >= 3.28.0 is required on Windows")
5252

5353
for ext in self.extensions:
5454
self.build_extension(ext)
@@ -151,7 +151,7 @@ def build_extension(self, ext):
151151
"packaging",
152152
"setuptools>=75.2.0",
153153
"pybind11[global]",
154-
"cmake~=3.31.0",
154+
"cmake~=3.28.1",
155155
],
156156
extras_require={
157157
"dev": dev_requirements,

0 commit comments

Comments
 (0)