Skip to content

Update some CMake files to add missing constructs & remove obsolete ones #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mhucka merged 4 commits into from
Jun 9, 2025
Merged

Update some CMake files to add missing constructs & remove obsolete ones #739

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
93c414a
Remove obsolete constructs from GetPybind11.cmake
mhucka May 29, 2025
c3f947a
Add missing project declaration
mhucka May 29, 2025
f17df1d
Merge branch 'master' into mh-update-cmake-files
mhucka Jun 9, 2025
c7f2b67
Add cmake file rules to .editorconfig
mhucka Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ max_line_length = 80
[{BUILD,*.BUILD,*.bzl,*.bazel,.bazelrc}]
indent_size = 4

[{CMakeLists.txt,*.cmake}]
indent_size = 4

[{*.cc,*.h}]
indent_size = 2

Expand Down
2 changes: 2 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
project(qsim)

set(CMAKE_CXX_STANDARD 11)
cmake_minimum_required(VERSION 3.31)

Expand Down
3 changes: 1 addition & 2 deletions pybind_interface/GetPybind11.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,5 @@ if (pybind11_FOUND)
endif()

if((NOT pybind11_FOUND) AND (NOT pybind11_POPULATED)) # check first on system path, then attempt git fetch
FetchContent_Populate(pybind11)
add_subdirectory(${pybind11_SOURCE_DIR} ${pybind11_BINARY_DIR})
FetchContent_MakeAvailable(pybind11)
endif()
Loading