Update some CMake files to add missing constructs & remove obsolete ones#739
Merged
Update some CMake files to add missing constructs & remove obsolete ones#739
Conversation
These constructs cause failures with newer versions of cmake.
The lack of a `project(qsim)` declaration may not have been a problem with old versions of cmake, but in newer versions, its absence causes build failures.
mhucka
changed the title
mhucka
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates two CMake files:
CMakeLists.txtfile was missing aproject()declaration. The lack of aproject(qsim)declaration may have worked with old versions of cmake, but in newer versions, its absence causes build failures.pybind_interface/GetPybind11.cmake. These cause failures with newer versions of CMake.