[FEATURE] Give DirectiveNode logger info, migrate logging directives - #1383
Merged
Conversation
linawolf
force-pushed
the
task/directive-logger-info
branch
from
September 3, 2026 14:47
fd037ad to
471caa5
Compare
jaapio
reviewed
Sep 3, 2026
jaapio
left a comment
jaapio
left a comment
Member
There was a problem hiding this comment.
Can we create an object for the logger info? I'm not sure what is in there. The filename and location? What else?
Contributor
Author
|
@jaapio done |
jaapio
approved these changes
Sep 4, 2026
Part of the #1373 directive migration: TestLoggerDirective, SectionauthorDirective, ConfigurationBlockDirective, and TabsDirective/TabDirective couldn't move to the #[Directive] model because they need live parser access to log a warning with file/line context, which createNode() doesn't have -- one of the blockers found in #1378. DirectiveNode now carries that context, captured once its content is fully parsed (matching what the old dispatch would have seen -- captured earlier gave a wrong line number), removing the blocker for this class of directive. TabsDirective and TabDirective are migrated together: migrating TabDirective alone previously broke tabs_html, since TabsDirective inspects its children's concrete type and only resolves correctly once both are on the compile-time model together. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PP4LkejR5PSubbhNmF4RkT Signed-off-by: lina.wolf
A directive's structure is fixed (file, line, current line) but was still passed around as a loosely-typed array. A dedicated object makes that structure explicit and self-documenting. Signed-off-by: lina.wolf Assisted-by: Claude Sonnet 5 <noreply@anthropic.com>
jaapio
force-pushed
the
task/directive-logger-info
branch
from
September 4, 2026 14:54
df09251 to
275bf39
Compare
jaapio
enabled auto-merge
September 4, 2026 14:54
Member
|
Thanks this is nice! |
linawolf
pushed a commit
that referenced
this pull request
Sep 5, 2026
Continues the #1373 migration now that #1383 landed. Migrates the directives that don't hit #1378's known ordering hazards -- Card Group/Grid, Accordion, Table, LaTeXMain. Card, AccordionItem, CardHeader/Image/Footer, and ListTable turned out to be blocked by two ordering hazards #1378 didn't cover; filed as a comment there rather than migrated. Stacked on #1388: this batch needed a directive's `:class:` option applied generically the way the old dispatch's postProcessNode() always did, which #1388 fixes underneath this branch. Signed-off-by: linawolf Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PP4LkejR5PSubbhNmF4RkT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[FEATURE] Give DirectiveNode logger info, migrate logging directives
Part of the #1373 directive migration: TestLoggerDirective,
SectionauthorDirective, ConfigurationBlockDirective, and
TabsDirective/TabDirective couldn't move to the #[Directive] model
because they need live parser access to log a warning with file/line
context, which createNode() doesn't have -- one of the blockers found
in #1378. DirectiveNode now carries that context, captured once its
content is fully parsed (matching what the old dispatch would have
seen -- captured earlier gave a wrong line number), removing the
blocker for this class of directive.
TabsDirective and TabDirective are migrated together: migrating
TabDirective alone previously broke tabs_html, since TabsDirective
inspects its children's concrete type and only resolves correctly
once both are on the compile-time model together.
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01PP4LkejR5PSubbhNmF4RkT
Signed-off-by: lina.wolf