[TASK] Migrate directives unblocked by the logger-info fix - #1385
Merged
linawolf merged 1 commit intoSep 5, 2026
Merged
Conversation
linawolf
pushed a commit
that referenced
this pull request
Sep 5, 2026
Continues the #1373 migration. Both directives resolve their image path relative to the current document's directory -- the one piece of BlockContext access createNode() couldn't reach until now. Safe to snapshot at parse time, unlike e.g. the code-block default language: a document's own path never changes mid-parse. DirectiveSourceLocation gains a documentDirectory field for this. Migrating ImageDirective also exposed a second, bigger gap: DirectiveProcessPass only ever merged `:class:` onto the returned node, never the other scalar options (width, alt, ...) the old dispatch's postProcessNode() always applied automatically. Fixed there directly, replacing the narrower parse-time-only `:class:` fix from PR #1385. Adds an integration fixture locking in existing, unaffected behavior: an image path inside `.. include::`d content resolves relative to whichever document contains the include, not the included snippet's own location. Signed-off-by: linawolf Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PP4LkejR5PSubbhNmF4RkT
Continues the #1373 migration now that #1383 landed. Migrates the directives that don't hit #1378's known ordering hazards -- Card Group/Grid, Accordion, Table, LaTeXMain. Card, AccordionItem, CardHeader/Image/Footer, and ListTable turned out to be blocked by two ordering hazards #1378 didn't cover; filed as a comment there rather than migrated. Stacked on #1388: this batch needed a directive's `:class:` option applied generically the way the old dispatch's postProcessNode() always did, which #1388 fixes underneath this branch. Signed-off-by: linawolf Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PP4LkejR5PSubbhNmF4RkT
linawolf
force-pushed
the
task/migrate-more-directives
branch
from
September 5, 2026 08:23
72ea2e9 to
82b9298
Compare
linawolf
changed the base branch from
main
to
task/directive-process-pass-options
September 5, 2026 08:23
linawolf
merged commit Sep 5, 2026
75a7994
into
task/directive-process-pass-options
58 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continues the #1373 migration now that #1383 landed. Migrates the
directives that don't hit #1378's known ordering hazards -- Card
Group/Grid, Accordion, Table, LaTeXMain.
Card, AccordionItem, CardHeader/Image/Footer, and ListTable turned
out to be blocked by two ordering hazards #1378 didn't cover; filed
as a comment there rather than migrated.
Stacked on #1388: this batch needed a directive's
:class:optionapplied generically the way the old dispatch's postProcessNode()
always did, which #1388 fixes underneath this branch.
Signed-off-by: linawolf
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01PP4LkejR5PSubbhNmF4RkT