Skip to content

docs: correct TableV2 size mapping and pager testid in antd-migration guide #32773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
detail-app wants to merge 1 commit into
base: main
Choose a base branch
from
Open

docs: correct TableV2 size mapping and pager testid in antd-migration guide #32773

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/antd-migration/table.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ compile rather than rendering a table that quietly lost a feature.
| Prop | Change |
|---|---|
| `customPaginationProps` | now **requires** `pagination={false}` alongside it — the parent owns paging and has already fetched exactly this page, so slicing again would drop rows |
| `size` | AntD `small` → core `compact`, `large` → `md`, unset → `sm`. Note that AntD tables not inside a `TableCard` were previously rendered at `md` because the core `size` prop was inert |
| `size` | AntD `small` → core `sm`, `middle`/`large`/unset → `md`. Note that AntD tables not inside a `TableCard` were previously rendered at `md` because the core `size` prop was inert |

## Test selector contract

Expand All @@ -56,7 +56,7 @@ rewritten now keeps passing through the sweep:
| selection control | `input[type="checkbox"]` | radio in single-selection mode |
| toolbar | `[data-testid="table-toolbar"]` | TableV2 only |
| column customize | `[data-testid="column-dropdown"]` | both |
| pager | `[data-testid="pagination"]` | via `NextPrevious` |
| pager | `[data-testid="pagination"]` | via `NextPrevious` only (with `customPaginationProps`); the default TableV2 pager has `[data-testid="next"]` instead |

No shared hook exists for these — migrate them in the sweep PR that moves the page:

Expand Down
Loading