Skip to content

docs: correct TableV2 size mapping and pager testid in antd-migration guide - #32773

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/fix-docs/docs-correct-tablev2-size-mapping-and-pager-testid-57b452
Open

docs: correct TableV2 size mapping and pager testid in antd-migration guide#32773
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/fix-docs/docs-correct-tablev2-size-mapping-and-pager-testid-57b452

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 6, 2026

Copy link
Copy Markdown

Describe your changes:

Fixes #31953

I worked on correcting two rows in docs/antd-migration/table.md that were
rendered stale by later sub-steps of the same squash commit that introduced the
file, because the doc described an intermediate state rather than the final
code.

  • The size row claimed AntD small -> core compact, large -> md, unset -> sm,
    but CORE_SIZE_BY_ANTD_SIZE in TableV2.tsx maps small -> sm and
    middle/large/unset -> md (with compact reachable only via an
    explicit size="compact").
  • The pager row claimed [data-testid="pagination"] is shared via
    NextPrevious, but the default TableV2 pager is now
    PaginationCardWithControls (testids next/previous/rows-per-page-dropdown);
    NextPrevious only renders when customPaginationProps is set.

A migrator relying on either row as-written would pick the wrong core size
(denser than intended for small tables) and write Playwright selectors
against [data-testid="pagination"] that never match the default pager.

Introduced by commit 2e08857 (@harsh-vador, #31953)

Type of change:

  • Documentation

High-level design:

N/A — small change.

Tests:

N/A — documentation only; no code or UI behaviour changed. Verified against
TableV2.tsx (CORE_SIZE_BY_ANTD_SIZE, default pager rendering) and the
parity suite (table.test.tsx size assertions, TableV2.parity.test.tsx
pager expectations).

UI screen recording / screenshots:

Not applicable.

Checklist:

  • I have read the CONTRIBUTING document.

Doc Drift PRs can be configured here.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit bc8163449d038df07a8da7ef6c742117a17af35d in Playwright run 34068504783, attempt 1.

✅ 557 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 32m 26s

⏱️ Max setup 4m 31s · max shard execution 15m 24s · max shard-job elapsed before upload 18m 33s · reporting 4s

🌐 235.69 requests/attempt · 2.82 app boots/UI scenario · 16.88% common-shard skew

Optimization targets still in progress:

  • Common shard skew was 16.88% (convergence target: at most 15%).
  • Browser traffic was 235.69 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.82 per UI scenario (1629 boots / 578 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 135 0 0 0 0 0
✅ Shard chromium-02 135 0 0 0 0 0
✅ Shard chromium-03 129 0 0 0 0 0
✅ Shard data-asset-rules-01 65 0 0 0 0 0
✅ Shard domain-isolation-01 16 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant