docs: correct TableV2 size mapping and pager testid in antd-migration guide - #32773
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
✅ Playwright Results — workflow succeededValidated commit ✅ 557 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 32m 26s ⏱️ Max setup 4m 31s · max shard execution 15m 24s · max shard-job elapsed before upload 18m 33s · reporting 4s 🌐 235.69 requests/attempt · 2.82 app boots/UI scenario · 16.88% common-shard skew Optimization targets still in progress:
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Describe your changes:
Fixes #31953
I worked on correcting two rows in
docs/antd-migration/table.mdthat wererendered stale by later sub-steps of the same squash commit that introduced the
file, because the doc described an intermediate state rather than the final
code.
sizerow claimedAntD small -> core compact, large -> md, unset -> sm,but
CORE_SIZE_BY_ANTD_SIZEinTableV2.tsxmapssmall -> smandmiddle/large/unset ->md(withcompactreachable only via anexplicit
size="compact").[data-testid="pagination"]is shared viaNextPrevious, but the default TableV2 pager is nowPaginationCardWithControls(testidsnext/previous/rows-per-page-dropdown);NextPreviousonly renders whencustomPaginationPropsis set.A migrator relying on either row as-written would pick the wrong core
size(denser than intended for
smalltables) and write Playwright selectorsagainst
[data-testid="pagination"]that never match the default pager.Introduced by commit 2e08857 (@harsh-vador, #31953)
Type of change:
High-level design:
N/A — small change.
Tests:
N/A — documentation only; no code or UI behaviour changed. Verified against
TableV2.tsx(CORE_SIZE_BY_ANTD_SIZE, default pager rendering) and theparity suite (
table.test.tsxsize assertions,TableV2.parity.test.tsxpager expectations).
UI screen recording / screenshots:
Not applicable.
Checklist:
Doc Drift PRs can be configured here.