Skip to content

docs: correct no-duplicate-string severity after i18n-aware rule split #32771

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
detail-app wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −1
Open

docs: correct no-duplicate-string severity after i18n-aware rule split #32771

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion docs/ui-code-quality-gate.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,9 @@ that already runs on every UI PR. A finding in your editor is the finding Sonar

The high-backlog SonarJS rules are also enforced *blockingly* by SonarCloud, whose Clean-as-You-Code
model scopes them to **new lines** — something ESLint fundamentally cannot express. So
`cognitive-complexity` and `no-duplicate-string` warn locally and block on new code in the PR gate.
`cognitive-complexity` warns locally and blocks on new code in the PR gate. The stock
`sonarjs/no-duplicate-string` is `off` because it flags i18n keys (`t('label.…')`) that must stay
inline; the i18n-aware `openmetadata-i18n/no-duplicate-string` replacement is enforced at `error`.

`eslint-plugin-sonarjs` is pinned **exactly** (`4.2.0`). SonarCloud upgrades its analyzer server-side
on its own schedule and that drift is silent.
Expand Down
Loading