docs: correct no-duplicate-string severity after i18n-aware rule split - #32771
Conversation
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
✅ Playwright Results — workflow succeededValidated commit ✅ 557 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 38m 35s ⏱️ Max setup 4m 23s · max shard execution 19m 28s · max shard-job elapsed before upload 22m 44s · reporting 5s 🌐 234.70 requests/attempt · 2.82 app boots/UI scenario · 17.21% common-shard skew Optimization targets still in progress:
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Describe your changes
Corrected
docs/ui-code-quality-gate.md, which claimedno-duplicate-string"warns locally and blocks on new code in the PR gate." That was true before
commit a7c407c split the rule: the stock
sonarjs/no-duplicate-stringis nowoff(it flags i18n keys liket('label.…')that must stay inline), and thei18n-aware
openmetadata-i18n/no-duplicate-stringreplacement is enforced aterror.A developer reading the stale sentence would believe a non-i18n duplicate
literal only produces a non-blocking local warning and is gated to new code
in SonarCloud. In reality the replacement rule fails
ui-checkstyleoutrightat error severity, on all lines.
Type of change
High-level design
N/A — small change.
Tests
Not applicable — documentation only.
UI screen recording / screenshots
Not applicable.
Checklist
Introduced by commit a7c407c (@ShaileshParmar11, #32270)
Detail: Doc Drift
Doc Drift PRs can be configured here.