Skip to content

docs: correct no-duplicate-string severity after i18n-aware rule split - #32771

Open
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/fix-docs/docs-correct-no-duplicate-string-severity-after-i1-cdd87f
Open

docs: correct no-duplicate-string severity after i18n-aware rule split#32771
detail-app[bot] wants to merge 1 commit into
mainfrom
detail/fix-docs/docs-correct-no-duplicate-string-severity-after-i1-cdd87f

Conversation

@detail-app

@detail-app detail-app Bot commented Sep 6, 2026

Copy link
Copy Markdown

Describe your changes

Corrected docs/ui-code-quality-gate.md, which claimed no-duplicate-string
"warns locally and blocks on new code in the PR gate." That was true before
commit a7c407c split the rule: the stock sonarjs/no-duplicate-string is now
off (it flags i18n keys like t('label.…') that must stay inline), and the
i18n-aware openmetadata-i18n/no-duplicate-string replacement is enforced at
error.

A developer reading the stale sentence would believe a non-i18n duplicate
literal only produces a non-blocking local warning and is gated to new code
in SonarCloud. In reality the replacement rule fails ui-checkstyle outright
at error severity, on all lines.

Type of change

  • Documentation

High-level design

N/A — small change.

Tests

Not applicable — documentation only.

UI screen recording / screenshots

Not applicable.

Checklist

  • I have read the CONTRIBUTING document.

Introduced by commit a7c407c (@ShaileshParmar11, #32270)

Detail: Doc Drift


Doc Drift PRs can be configured here.

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

Hi there 👋 Thanks for your contribution!

The OpenMetadata team will review the PR shortly! Once it has been labeled as safe to test, the CI workflows
will start executing and we'll be able to make sure everything is working as expected.

Let us know if you need any help!

@github-actions

github-actions Bot commented Sep 6, 2026

Copy link
Copy Markdown
Contributor

✅ Playwright Results — workflow succeeded

Validated commit ce082c76f6fe5bd4428647bf3268d2c76c3c18f9 in Playwright run 34068648357, attempt 1.

✅ 557 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky

Performance

Blocking targets: ✅ met · Optimization targets: 🟡 in progress

Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting.

🕒 Full workflow signal wall (to summary) 38m 35s

⏱️ Max setup 4m 23s · max shard execution 19m 28s · max shard-job elapsed before upload 22m 44s · reporting 5s

🌐 234.70 requests/attempt · 2.82 app boots/UI scenario · 17.21% common-shard skew

Optimization targets still in progress:

  • Common shard skew was 17.21% (convergence target: at most 15%).
  • Browser traffic was 234.7 requests per attempt (convergence target: fewer than 200).
  • Application boot ratio was 2.82 per UI scenario (1630 boots / 578 scenarios; convergence target: at most 1).
Shard Passed Failed Flaky Skipped Lifecycle failed Lifecycle flaky
✅ Shard chromium-01 133 0 0 0 0 0
✅ Shard chromium-02 140 0 0 0 0 0
✅ Shard chromium-03 126 0 0 0 0 0
✅ Shard data-asset-rules-01 65 0 0 0 0 0
✅ Shard domain-isolation-01 16 0 0 0 0 0
✅ Shard global-state-01 34 0 0 0 0 0
✅ Shard ingestion-01 1 0 0 0 0 0
✅ Shard reindex-01 2 0 0 0 0 0
✅ Shard search-01 11 0 0 0 0 0
✅ Shard search-rbac-01 29 0 0 0 0 0

📦 Download artifacts

How to debug locally
# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip    # view trace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

safe to test Add this label to run secure Github workflows on PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant