Skip to content

Fixes #26451: return 400 for a base URL setting with no configValue #32767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Khairajani wants to merge 2 commits into
base: main
Choose a base branch
from
+12 −3
Open

Fixes #26451: return 400 for a base URL setting with no configValue #32767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07be320
Fixes #26451: return 400 for a base URL setting with no configValue
Khairajani Sep 6, 2026
c6ec44d
Merge branch 'main' into fix-26451-null-configvalue
Khairajani Sep 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ...ata-service/src/main/java/org/openmetadata/service/util/OpenMetadataBaseUrlValidator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,9 @@ public static void validate(Settings setting) {
setting != null
&& setting.getConfigType() == SettingsType.OPEN_METADATA_BASE_URL_CONFIGURATION;
if (isBaseUrlSetting) {
validateUrl(
JsonUtils.convertValue(setting.getConfigValue(), OpenMetadataBaseUrlConfiguration.class)
.getOpenMetadataUrl());
OpenMetadataBaseUrlConfiguration config =
JsonUtils.convertValue(setting.getConfigValue(), OpenMetadataBaseUrlConfiguration.class);
validateUrl(config == null ? null : config.getOpenMetadataUrl());
}
}

Expand Down
9 changes: 9 additions & 0 deletions ...service/src/test/java/org/openmetadata/service/util/OpenMetadataBaseUrlValidatorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,15 @@ void acceptsBaseUrlSettingWithScheme() {
assertDoesNotThrow(() -> OpenMetadataBaseUrlValidator.validate(setting));
}

@Test
void rejectsBaseUrlSettingWithoutConfigValue() {
Settings setting =
new Settings().withConfigType(SettingsType.OPEN_METADATA_BASE_URL_CONFIGURATION);

assertThrows(
SystemSettingsException.class, () -> OpenMetadataBaseUrlValidator.validate(setting));
}

@Test
void ignoresOtherSettingTypes() {
Settings setting =
Expand Down
Loading