Fixes #26451: return 400 for a base URL setting with no configValue - #32767
Fixes #26451: return 400 for a base URL setting with no configValue#32767Khairajani wants to merge 2 commits into
Conversation
`configValue` is optional in settings.json (only `config_type` is required) and `JsonUtils.convertValue` returns null for a null input, so a base-URL setting posted without a `configValue` dereferenced null and produced a 500 instead of the intended 400.
❌ PR checklist incompleteThis PR cannot be merged until the following are addressed on its linked issue:
The fields live on the linked issue in the Shipping project (open the issue → right sidebar → Projects). After you set them, re-run this check (or push a commit) — issue/project changes do not re-trigger it automatically. Maintainers can bypass this check by adding the |
|
Hi there 👋 Thanks for your contribution! The OpenMetadata team will review the PR shortly! Once it has been labeled as Let us know if you need any help! |
✅ Playwright Results — workflow succeededValidated commit ✅ 557 passed · ❌ 0 failed · 🟡 0 flaky · ⏭️ 0 skipped · 🧰 0 lifecycle flaky PerformanceBlocking targets: ✅ met · Optimization targets: 🟡 in progress Shard-job maxima below are not the full workflow wall time; the linked run includes build, fixture, planning, and reporting. 🕒 Full workflow signal wall (to summary) 54m 26s ⏱️ Max setup 5m 9s · max shard execution 18m 40s · max shard-job elapsed before upload 22m 15s · reporting 5s 🌐 235.58 requests/attempt · 2.82 app boots/UI scenario · 26.07% common-shard skew Optimization targets still in progress:
How to debug locally# Download playwright-test-results-<shard> artifact and unzip
npx playwright show-trace path/to/trace.zip # view trace |
Code Review ✅ ApprovedAdds a null check to prevent a 500 error when OptionsDisplay: compact → Showing less information. Comment with these commands to change the behavior for this request:
Was this helpful? React with 👍 / 👎 | Powered by Gitar — free for open source |
Follow-up to #32542.
configValueis optional insettings.json(onlyconfig_typeis required) andJsonUtils.convertValuereturns null for a null input, soPUT /v1/system/settingswith{"config_type": "openMetadataBaseUrlConfiguration"}and noconfigValuedereferenced null — a 500 instead of the intended 400.Guarded, and covered by a test that reproduces the NPE without the fix.