Skip to content

Update coding standards to PSR12 and improve CONTRIBUTING.md #716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
n0nag0n merged 8 commits into from
Aug 17, 2026
Merged

Update coding standards to PSR12 and improve CONTRIBUTING.md #716

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
dddd6ab
update the coding standards to PSR12
fadrian06 Aug 14, 2026
412faa1
adjust the php versions in the tests
fadrian06 Aug 14, 2026
fa08cd6
remove restriction about the ! (NOT) operator
fadrian06 Aug 14, 2026
a86e407
improve the redaction of CONTRIBUTING.md about security vulnerabilities
fadrian06 Aug 14, 2026
b464dc1
PSR12 -> PSR-12
fadrian06 Aug 14, 2026
ae0440e
remove "Until automated testing is put into place"
fadrian06 Aug 14, 2026
d566684
improve redaction about reporting security vulnerabilities
fadrian06 Aug 14, 2026
cc01169
falsey -> falsy
fadrian06 Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,19 +9,19 @@ Flight aims to be simple and fast. Anything that compromises either of those two

* **Dependencies** - We strive to be dependency free in Flight. Yes even polyfills, yes even `Interface` only repos like `psr/container`. The fewer dependencies, the fewer your exposed attack vectors.

* **Coding Standards** - We use PSR1 coding standards enforced by PHPCS. Some standards that either need additional configuration or need to be manually done are:
* **Coding Standards** - We use PSR-12 coding standards enforced by PHPCS. Some standards that either need additional configuration or need to be manually done are:
* PHPStan is at level 6.
* `===` instead of truthy or falsey statements like `==` or `!is_array()`.
* `===` instead of truthy or falsy statements like `==`.

* **PHP 7.4 Focused** - We do not make PHP 8+ focused enhancements on the framework as the focus is maintaining PHP 7.4.

* **Core functionality vs Plugin** - Have a conversation with us in the [chatroom](https://matrix.to/#/!cTfwPXhpkTXPXwVmxY:matrix.org?via=matrix.org&via=leitstelle511.net&via=integrations.ems.host) to know if your idea is worth makes sense in the framework or in a plugin.

* **Testing** - Until automated testing is put into place, any PRs must pass unit testing in PHP 7.4 and PHP 8.2+. Additionally you need to run `composer test-server` and `composer test-server-v2` and ensure all the header links work correctly.
* **Testing** - PRs must pass unit tests on PHP 7.4 through PHP 8.5+. Additionally you need to run `composer test-server` and `composer test-server-v2` and ensure all the header links work correctly.

#### **Did you find a bug?**

* **Do not open up a GitHub issue if the bug is a security vulnerability**. Instead contact maintainers directly via email to safely pass in the information related to the security vuln.
* **Do not open up a GitHub issue if the bug is a security vulnerability**. Instead contact maintainers directly via email to safely share details about the security vulnerability.

* **Ensure the bug was not already reported** by searching on GitHub under [Issues](https://github.com/flightphp/core/issues).

Expand Down