Skip to content

Update coding standards to PSR12 and improve CONTRIBUTING.md - #716

Merged
n0nag0n merged 8 commits into
masterfrom
update-contributing-guidelines
Aug 17, 2026
Merged

Update coding standards to PSR12 and improve CONTRIBUTING.md#716
n0nag0n merged 8 commits into
masterfrom
update-contributing-guidelines

Conversation

@fadrian06

Copy link
Copy Markdown
Contributor

This pull request updates the project's contribution guidelines in CONTRIBUTING.md to reflect current coding standards and testing requirements. The main changes clarify the coding standard version, supported PHP versions, and improve language consistency.

Documentation updates:

  • Updated coding standards from PSR1 to PSR12 and clarified that PSR12 is enforced by PHPCS.
  • Updated testing requirements to specify support for PHP 7.4 through PHP 8.5+ (previously only mentioned 8.2+).
  • Improved wording for consistency (e.g., "security vuln" changed to "security vulnerability").
  • Clarified the example for strict comparison (===) by removing mention of !is_array() as a falsey statement example.

Copilot AI lite review requested due to automatic review settings August 14, 2026 03:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates CONTRIBUTING.md to reflect current contribution expectations, especially around coding standards, PHP version support, and testing guidance for FlightPHP/Core contributors.

Changes:

  • Updates the stated coding standard from PSR-1 to PSR-12 and adjusts the strict-comparison example.
  • Expands the documented unit-test PHP version range to include PHP 7.4 through PHP 8.5+.
  • Improves wording around responsible security vulnerability reporting.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
fadrian06 and others added 4 commits August 14, 2026 00:58
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
CI Tests were implemented and running successfully

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@n0nag0n
n0nag0n merged commit 73a5387 into master Aug 17, 2026
21 checks passed
@n0nag0n
n0nag0n deleted the update-contributing-guidelines branch August 17, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants