Skip to content

dev → main: bug template @debug field + sp_IndexCleanup uptime/UDF fixes #770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
erikdarlingdata merged 4 commits into from
Apr 27, 2026
Merged

dev → main: bug template @debug field + sp_IndexCleanup uptime/UDF fixes #770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f703669
Ask for @debug output in bug report template
erikdarlingdata Apr 26, 2026
7ce59dc
Surface server uptime in sp_IndexCleanup header row and replace strin…
erikdarlingdata Apr 27, 2026
a51f606
Merge pull request #768 from erikdarlingdata/add-debug-field-bug-temp…
erikdarlingdata Apr 27, 2026
4706985
Merge pull request #769 from erikdarlingdata/fix-indexcleanup-udf-det…
erikdarlingdata Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,16 @@ body:
validations:
required: false

- type: textarea
id: debug
attributes:
label: Debug Output
description: |
If the script supports `@debug = 1` (sp_QuickieStore, sp_HealthParser, sp_PressureDetector, sp_PerfCheck, sp_IndexCleanup, sp_LogHunter, sp_HumanEvents, sp_QueryStoreCleanup, sp_QueryReproBuilder), please re-run with `@debug = 1` and paste the **Messages tab** output — especially the last `current_table` value and the failing dynamic SQL block. This pinpoints which section is broken and is usually all we need to ship a fix.
render: text
validations:
required: false

- type: textarea
id: context
attributes:
Expand Down
159 changes: 96 additions & 63 deletions sp_IndexCleanup/sp_IndexCleanup.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1786,49 +1786,60 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
column_name = c.name,
definition = cc.definition,
/*
UDF detection: Looks for schema-qualified object references like [schema].[function]
Note: This is a heuristic check and may have rare false positives if ].[ appears
in string literals or comments within the computed column definition
UDF detection: Uses sys.sql_expression_dependencies, filtered to user-defined
function object types (FN, IF, TF, FS, FT). This avoids the false positives
the previous string-heuristic produced for schema-qualified type names,
system functions called as [sys].[fn_xxx](), and ].[ embedded in string
literals or comments.
*/
contains_udf =
CASE
WHEN cc.definition LIKE ''%|].|[%'' ESCAPE ''|''
AND cc.definition LIKE ''%|].|[%(%'' ESCAPE ''|''
WHEN refs.udf_names IS NOT NULL
THEN 1
ELSE 0
END,
udf_names =
CASE
WHEN cc.definition LIKE ''%|].|[%'' ESCAPE ''|''
AND cc.definition LIKE ''%|].|[%(%'' ESCAPE ''|''
AND CHARINDEX(N''['', cc.definition) > 0
AND CHARINDEX(N''].['', cc.definition) > 0
AND CHARINDEX(N'']'', cc.definition, CHARINDEX(N''].['', cc.definition) + 3) > 0
THEN
SUBSTRING
(
cc.definition,
CHARINDEX(N''['', cc.definition),
CHARINDEX
(
N'']'',
cc.definition,
CHARINDEX
(
N''].['',
cc.definition
) + 3
) -
CHARINDEX(N''['', cc.definition) + 1
)
ELSE NULL
END
udf_names = refs.udf_names
FROM #filtered_objects AS fo
JOIN ' + QUOTENAME(@current_database_name) + N'.sys.columns AS c
ON fo.object_id = c.object_id
JOIN ' + QUOTENAME(@current_database_name) + N'.sys.computed_columns AS cc
ON c.object_id = cc.object_id
AND c.column_id = cc.column_id
OUTER APPLY
(
SELECT
udf_names =
STUFF
(
(
SELECT
N'', '' +
QUOTENAME(s.name) +
N''.'' +
QUOTENAME(o.name)
FROM ' + QUOTENAME(@current_database_name) + N'.sys.sql_expression_dependencies AS sed
JOIN ' + QUOTENAME(@current_database_name) + N'.sys.objects AS o
ON o.object_id = sed.referenced_id
JOIN ' + QUOTENAME(@current_database_name) + N'.sys.schemas AS s
ON s.schema_id = o.schema_id
WHERE sed.referencing_id = cc.object_id
AND sed.referencing_minor_id = cc.column_id
AND sed.referencing_class = 1
AND sed.referenced_class = 1
AND o.type IN (N''FN'', N''IF'', N''TF'', N''FS'', N''FT'')
ORDER BY
s.name,
o.name
FOR
XML
PATH(N''''),
TYPE
).value(''.'', ''nvarchar(max)''),
1,
2,
N''''
)
) AS refs
OPTION(RECOMPILE);';

IF @debug = 1
Expand Down Expand Up @@ -1883,46 +1894,56 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
constraint_name = cc.name,
definition = cc.definition,
/*
UDF detection: Looks for schema-qualified object references like [schema].[function]
Note: This is a heuristic check and may have rare false positives if ].[ appears
in string literals or comments within the computed column definition
UDF detection: Uses sys.sql_expression_dependencies, filtered to user-defined
function object types (FN, IF, TF, FS, FT). This avoids the false positives
the previous string-heuristic produced for schema-qualified type names,
system functions called as [sys].[fn_xxx](), and ].[ embedded in string
literals or comments.
*/
contains_udf =
CASE
WHEN cc.definition LIKE ''%|].|[%'' ESCAPE ''|''
AND cc.definition LIKE ''%|].|[%(%'' ESCAPE ''|''
WHEN refs.udf_names IS NOT NULL
THEN 1
ELSE 0
END,
udf_names =
CASE
WHEN cc.definition LIKE ''%|].|[%'' ESCAPE ''|''
AND cc.definition LIKE ''%|].|[%(%'' ESCAPE ''|''
AND CHARINDEX(N''['', cc.definition) > 0
AND CHARINDEX(N''].['', cc.definition) > 0
AND CHARINDEX(N'']'', cc.definition, CHARINDEX(N''].['', cc.definition) + 3) > 0
THEN
SUBSTRING
(
cc.definition,
CHARINDEX(N''['', cc.definition),
CHARINDEX
(
N'']'',
cc.definition,
CHARINDEX
(
N''].['',
cc.definition
) + 3
) -
CHARINDEX(N''['', cc.definition) + 1
)
ELSE NULL
END
udf_names = refs.udf_names
FROM #filtered_objects AS fo
JOIN ' + QUOTENAME(@current_database_name) + N'.sys.check_constraints AS cc
ON fo.object_id = cc.parent_object_id
OUTER APPLY
(
SELECT
udf_names =
STUFF
(
(
SELECT
N'', '' +
QUOTENAME(s.name) +
N''.'' +
QUOTENAME(o.name)
FROM ' + QUOTENAME(@current_database_name) + N'.sys.sql_expression_dependencies AS sed
JOIN ' + QUOTENAME(@current_database_name) + N'.sys.objects AS o
ON o.object_id = sed.referenced_id
JOIN ' + QUOTENAME(@current_database_name) + N'.sys.schemas AS s
ON s.schema_id = o.schema_id
WHERE sed.referencing_id = cc.object_id
AND sed.referencing_class = 1
AND sed.referenced_class = 1
AND o.type IN (N''FN'', N''IF'', N''TF'', N''FS'', N''FT'')
ORDER BY
s.name,
o.name
FOR
XML
PATH(N''''),
TYPE
).value(''.'', ''nvarchar(max)''),
1,
2,
N''''
)
) AS refs
OPTION(RECOMPILE);';

IF @debug = 1
Expand Down Expand Up @@ -4127,7 +4148,19 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
),
table_name = N'brought to you by erikdarling.com',
index_name = N'for support: https://code.erikdarling.com/',
consolidation_rule = N'run date: ' + CONVERT(nvarchar(30), SYSDATETIME(), 120),
consolidation_rule =
N'run date: ' +
CONVERT(nvarchar(30), SYSDATETIME(), 120) +
N' | ' +
CASE
WHEN @uptime_warning = 1
THEN N'WARNING: Server uptime only ' +
@uptime_days +
N' days - usage data may be incomplete!'
ELSE N'Server uptime: ' +
@uptime_days +
N' days'
END,
script_type = N'Index Cleanup Scripts',
additional_info = N'A detailed index analysis report appears after these scripts',
target_index_name = N'ALWAYS TEST THESE RECOMMENDATIONS',
Expand Down
Loading