dev → main: bug template @debug field + sp_IndexCleanup uptime/UDF fixes#770
Merged
erikdarlingdata merged 4 commits intomainfrom Apr 27, 2026
Merged
dev → main: bug template @debug field + sp_IndexCleanup uptime/UDF fixes#770erikdarlingdata merged 4 commits intomainfrom
erikdarlingdata merged 4 commits intomainfrom
Conversation
Add a Debug Output textarea to bug_report.yml asking reporters to re-run with @debug = 1 and paste the Messages output. Lists all procs that support @debug. The current_table value and failing dynamic SQL pinpoint the broken section without further round-trips. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…g-heuristic UDF detection Append a "Server uptime: N days" (or warning variant when uptime < 14 days) clause to the run-date header row's consolidation_rule, so the day count is visible alongside per-row warnings rather than only in the summary block. Replace the LIKE '%].[%(%' heuristic that flagged computed columns and check constraints as containing UDFs. The pattern fired on string literals containing ].[ ( bracketed schema-qualified system functions like [sys].[fn_xxx](), and OBJECT_ID literals that include schema-qualified names. Use sys.sql_expression_dependencies filtered to FN/IF/TF/FS/FT object types instead, joined to sys.objects for the clean [schema].[name] list. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…late Ask for @debug output in bug report template
…ection sp_IndexCleanup: show uptime in header row, fix UDF false positives
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes two recently merged dev PRs to main:
@debugoutput field to the bug report template. Asks reporters to re-run with@debug = 1and paste the Messages-tab output, listing every proc that supports@debug. Pinpoints broken sections without follow-up round-trips.sp_IndexCleanup:consolidation_ruleso the day count is visible per-row, not just in the summarydatabase_infocell.LIKE '%].[%(%'UDF-detection heuristic for computed columns and check constraints with asys.sql_expression_dependenciesjoin filtered toFN/IF/TF/FS/FT. The heuristic produced false positives for any definition containing].[(— including string literals,OBJECT_ID(N'[schema].[name](x)'), and any system function called as[sys].[fn_xxx]().udf_namesnow reports a clean[schema].[name]list instead of aSUBSTRING-from-first-bracket extract.Test plan
sp_IndexCleanupUDF detection validated end-to-end on SQL2022 against purpose-built false-positive bait (string literals with].[(,OBJECT_IDliterals with bracketed names, real UDF refs in both computed columns and check constraints) — see sp_IndexCleanup: show uptime in header row, fix UDF false positives #769 test plan