Skip to content

#583 [sp_PerfCheck Overflow Errors] #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
krustydb wants to merge 10 commits into from
Closed

#583 [sp_PerfCheck Overflow Errors] #584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8411e58
Markdown needs the escape character escaped
VladDBA Apr 19, 2025
8de71a3
Consistent PRIMARY KEY syntax.
ReeceGoding Apr 21, 2025
8e04cdc
Merge pull request #572 from VladDBA/dev
erikdarlingdata Apr 21, 2025
7ecff0d
Merge pull request #578 from ReeceGoding/dev
erikdarlingdata Apr 21, 2025
0ee921a
Made skipping maintenance plans optional, closes #577.
ReeceGoding Apr 22, 2025
3b7996a
Merge pull request #580 from ReeceGoding/dev
erikdarlingdata Apr 22, 2025
a5a7c77
Update sp_PerfCheck.sql
erikdarlingdata Apr 23, 2025
f5ac525
Merge branch 'dev' of https://github.com/erikdarlingdata/DarlingData …
erikdarlingdata Apr 23, 2025
c223c2f
Closes #582
erikdarlingdata Apr 24, 2025
9639d07
#583 sp_PerfCheck Overflow Errors
krustydb Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions sp_PerfCheck/sp_PerfCheck.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,7 +387,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
name sysname NOT NULL,
database_id integer NOT NULL,
compatibility_level tinyint NOT NULL,
collation_name sysname NOT NULL,
collation_name sysname NULL,
user_access_desc nvarchar(60) NOT NULL,
is_read_only bit NOT NULL,
is_auto_close_on bit NOT NULL,
Expand Down Expand Up @@ -2381,7 +2381,7 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
THEN 0
ELSE CONVERT(decimal(18, 2), SUM(fs.io_stall_write_ms) * 1.0 / SUM(fs.num_of_writes))
END,
total_size_mb = CONVERT(decimal(18, 2), SUM(mf.size) * 8.0 / 1024.0)
total_size_mb = CONVERT(decimal(18, 2), SUM(CONVERT(bigint, mf.size)) * 8.0 / 1024.0)
FROM sys.dm_io_virtual_file_stats
(' +
CASE
Expand Down Expand Up @@ -2581,9 +2581,9 @@ WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
CONVERT(nvarchar(10), CONVERT(decimal(10, 2), io.avg_write_stall_ms)) +
N' ms. ' +
N'Total read: ' +
CONVERT(nvarchar(20), CONVERT(decimal(10, 2), io.read_io_mb)) +
CONVERT(nvarchar(20), CONVERT(decimal(18, 2), io.read_io_mb)) +
N' MB, Total write: ' +
CONVERT(nvarchar(20), CONVERT(decimal(10, 2), io.write_io_mb)) +
CONVERT(nvarchar(20), CONVERT(decimal(18, 2), io.write_io_mb)) +
N' MB. ' +
N'This indicates slow I/O subsystem performance for this database.',
url = N'https://erikdarling.com/sp_PerfCheck#IOStalls'
Expand Down
2 changes: 1 addition & 1 deletion sp_PressureDetector/sp_PressureDetector.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -870,7 +870,7 @@ OPTION(MAXDOP 1, RECOMPILE);',
writes bigint NULL,
logical_reads bigint NULL,
granted_query_memory_gb decimal(38,2) NULL,
transaction_isolation_level nvarchar(30) NULL,
transaction_isolation_level sysname NULL,
dop integer NULL,
parallel_worker_count integer NULL,
plan_handle varbinary(64) NULL,
Expand Down
5 changes: 3 additions & 2 deletions sp_QuickieStore/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ Use the `@expert_mode` parameter to return additional details.
| @query_text_search | nvarchar | query text to search for | a string; leading and trailing wildcards will be added if missing | NULL |
| @query_text_search_not | nvarchar | query text to exclude | a string; leading and trailing wildcards will be added if missing | NULL |
| @escape_brackets | bit | Set this bit to 1 to search for query text containing square brackets (common in .NET Entity Framework and other ORM queries) | 0 or 1 | 0 |
| @escape_character | nchar | Sets the ESCAPE character for special character searches, defaults to the SQL standard backslash (\) character | some escape character, SQL standard is backslash (\) | \ |
| @escape_character | nchar | Sets the ESCAPE character for special character searches, defaults to the SQL standard backslash (\\) character | some escape character, SQL standard is backslash (\\) | \ |
| @only_queries_with_hints | bit | only return queries with query hints | 0 or 1 | 0 |
| @only_queries_with_feedback | bit | only return queries with query feedback | 0 or 1 | 0 |
| @only_queries_with_variants | bit | only return queries with query variants | 0 or 1 | 0 |
Expand All @@ -73,6 +73,7 @@ Use the `@expert_mode` parameter to return additional details.
| @regression_comparator | varchar | what difference to use ('relative' or 'absolute') when comparing @sort_order's metric for the normal time period with any regression time period. | relative, absolute | NULL; absolute if @regression_baseline_start_date is specified |
| @regression_direction | varchar | when comparing against any regression baseline, what do you want the results sorted by ('magnitude', 'improved', or 'regressed')? | regressed, worse, improved, better, magnitude, absolute, whatever | NULL; regressed if @regression_baseline_start_date is specified |
| @include_query_hash_totals | bit | will add an additional column to final output with total resource usage by query hash | 0 or 1 | 0 |
| @include_maintenance | bit | Set this bit to 1 to add maintenance operations such as index creation to the result set | 0 or 1 | 0 |
| @help | bit | how you got here | 0 or 1 | 0 |
| @debug | bit | prints dynamic sql, statement length, parameter and variable values, and raw temp table contents | 0 or 1 | 0 |
| @troubleshoot_performance | bit | set statistics xml on for queries against views | 0 or 1 | 0 |
Expand Down Expand Up @@ -129,4 +130,4 @@ EXECUTE dbo.sp_QuickieStore

## Resources
* [YouTube playlist](https://www.youtube.com/playlist?list=PLt4QZ-7lfQie1XZHEm0HN-Zt1S7LFEx1P)
* [Blog post](https://www.erikdarling.com/sp_quickiestore/)
* [Blog post](https://www.erikdarling.com/sp_quickiestore/)
20 changes: 15 additions & 5 deletions sp_QuickieStore/sp_QuickieStore.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,7 @@ ALTER PROCEDURE
@regression_comparator varchar(20) = NULL, /*what difference to use ('relative' or 'absolute') when comparing @sort_order's metric for the normal time period with the regression time period.*/
@regression_direction varchar(20) = NULL, /*when comparing against the regression baseline, want do you want the results sorted by ('magnitude', 'improved', or 'regressed')?*/
@include_query_hash_totals bit = 0, /*will add an additional column to final output with total resource usage by query hash, may be skewed by query_hash and query_plan_hash bugs with forced plans/plan guides*/
@include_maintenance bit = 0, /*Set this bit to 1 to add maintenance operations such as index creation to the result set*/
@help bit = 0, /*return available parameter details, etc.*/
@debug bit = 0, /*prints dynamic sql, statement length, parameter and variable values, and raw temp table contents*/
@troubleshoot_performance bit = 0, /*set statistics xml on for queries against views*/
Expand Down Expand Up @@ -215,6 +216,7 @@ BEGIN
WHEN N'@regression_comparator' THEN 'what difference to use (''relative'' or ''absolute'') when comparing @sort_order''s metric for the normal time period with any regression time period.'
WHEN N'@regression_direction' THEN 'when comparing against any regression baseline, what do you want the results sorted by (''magnitude'', ''improved'', or ''regressed'')?'
WHEN N'@include_query_hash_totals' THEN N'will add an additional column to final output with total resource usage by query hash, may be skewed by query_hash and query_plan_hash bugs with forced plans/plan guides'
WHEN N'@include_maintenance' THEN N'Set this bit to 1 to add maintenance operations such as index creation to the result set'
WHEN N'@help' THEN 'how you got here'
WHEN N'@debug' THEN 'prints dynamic sql, statement length, parameter and variable values, and raw temp table contents'
WHEN N'@troubleshoot_performance' THEN 'set statistics xml on for queries against views'
Expand Down Expand Up @@ -270,6 +272,7 @@ BEGIN
WHEN N'@regression_comparator' THEN 'relative, absolute'
WHEN N'@regression_direction' THEN 'regressed, worse, improved, better, magnitude, absolute, whatever'
WHEN N'@include_query_hash_totals' THEN N'0 or 1'
WHEN N'@include_maintenance' THEN N'0 or 1'
WHEN N'@help' THEN '0 or 1'
WHEN N'@debug' THEN '0 or 1'
WHEN N'@troubleshoot_performance' THEN '0 or 1'
Expand Down Expand Up @@ -325,6 +328,7 @@ BEGIN
WHEN N'@regression_comparator' THEN 'NULL; absolute if @regression_baseline_start_date is specified'
WHEN N'@regression_direction' THEN 'NULL; regressed if @regression_baseline_start_date is specified'
WHEN N'@include_query_hash_totals' THEN N'0'
WHEN N'@include_maintenance' THEN N'0'
WHEN N'@help' THEN '0'
WHEN N'@debug' THEN '0'
WHEN N'@troubleshoot_performance' THEN '0'
Expand Down Expand Up @@ -782,7 +786,7 @@ Hold plan_ids for matching wait filter
CREATE TABLE
#wait_filter
(
plan_id bigint PRIMARY KEY
plan_id bigint PRIMARY KEY CLUSTERED
);

/*
Expand Down Expand Up @@ -1276,19 +1280,19 @@ CREATE TABLE
CREATE TABLE
#include_databases
(
database_name sysname PRIMARY KEY
database_name sysname PRIMARY KEY CLUSTERED
);

CREATE TABLE
#exclude_databases
(
database_name sysname PRIMARY KEY
database_name sysname PRIMARY KEY CLUSTERED
);

CREATE TABLE
#requested_but_skipped_databases
(
database_name sysname PRIMARY KEY,
database_name sysname PRIMARY KEY CLUSTERED,
reason varchar(100) NOT NULL
);

Expand Down Expand Up @@ -2716,6 +2720,8 @@ SELECT
ISNULL(@workdays, 0),
@include_query_hash_totals =
ISNULL(@include_query_hash_totals, 0),
@include_maintenance =
ISNULL(@include_maintenance, 0),
/*
doing start and end date last because they're more complicated
if start or end date is null,
Expand Down Expand Up @@ -5145,7 +5151,8 @@ END;
/*
This section screens out index create and alter statements because who cares
*/

IF @include_maintenance = 0
BEGIN
SELECT
@current_table = 'inserting #maintenance_plans',
@sql = @isolation_level;
Expand Down Expand Up @@ -5225,6 +5232,7 @@ SELECT
FROM #maintenance_plans AS mp
WHERE mp.plan_id = qsrs.plan_id
)' + @nc10;
END;

/*
Tidy up the where clause a bit
Expand Down Expand Up @@ -10208,6 +10216,8 @@ BEGIN
@regression_direction,
include_query_hash_totals =
@include_query_hash_totals,
include_maintenance =
@include_maintenance,
help =
@help,
debug =
Expand Down
Loading