#583 [sp_PerfCheck Overflow Errors]#584
Closed
krustydb wants to merge 10 commits intoerikdarlingdata:mainfrom
Closed
#583 [sp_PerfCheck Overflow Errors]#584krustydb wants to merge 10 commits intoerikdarlingdata:mainfrom
krustydb wants to merge 10 commits intoerikdarlingdata:mainfrom
Conversation
sp_QuickieStore's Readme.md file - Markdown needs the escape character escaped
sp_QuickieStore: Consistent PRIMARY KEY syntax.
Nothing really intelligent done here. Boilerplate aside, I just wrapped the bit that does the skipping in an IF.
sp_QuickieStore: Made skipping maintenance plans optional
Msg 8115, Level 16, State 8, Procedure dbo.sp_PerfCheck, Line 2100 (Batch Start Line 2) Arithmethic overflow error converting numeric to data type numeric
Owner
|
@krustydb You're killing me buddy. Please read the contributing guide. You're trying to push into main. I only accept pull requests to the dev branch. |
Author
sorry, I'm on it, but this github thing is quite new to me |
Owner
|
@krustydb it's cool, I've made the decimal(18, 2) changes where you had them before in there. This one should be good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Msg 8115, Level 16, State 8, Procedure dbo.sp_PerfCheck, Line 2100 (Batch Start Line 2)
Arithmethic overflow error converting numeric to data type numeric