Skip to content

Manually parse urls - #2674

Merged
gingerbenw merged 6 commits into
nextfrom
gingerbenw/fixup-network-request-scenario
Feb 5, 2026
Merged

Manually parse urls#2674
gingerbenw merged 6 commits into
nextfrom
gingerbenw/fixup-network-request-scenario

Conversation

@gingerbenw

@gingerbenw gingerbenw commented Feb 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Goal

Removes the dependency on URL and URLSearchParams APIs from React Native test fixtures and network instrumentation code, replacing them with manual string parsing to avoid requiring polyfills in React Native environments.

Changeset

  • Implemented custom query parameter parsing and URL manipulation functions to avoid URLSearchParams dependency
  • Updated test expectations to reflect the simplified URL format (removed trailing slash before query parameter)
  • Nullify some console logging during unit tests
  • Update invalid unhandled assertions in browser http error tests

@github-actions

github-actions Bot commented Feb 2, 2026 •
edited
Loading

Copy link
Copy Markdown

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 50.69 kB 15.03 kB
After 50.69 kB 15.03 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 7e7c468

@gingerbenw
gingerbenw force-pushed the gingerbenw/fixup-network-request-scenario branch from 148ab4d to 96cb9ba Compare February 2, 2026 15:47
@gingerbenw gingerbenw changed the title test: ✅ fix react native test, removing need for pol… Removing URL.search from native test fixture Feb 2, 2026
@gingerbenw gingerbenw changed the title Removing URL.search from native test fixture Manually construct fetch url in react native test fixture Feb 2, 2026
@gingerbenw
gingerbenw force-pushed the gingerbenw/fixup-network-request-scenario branch 2 times, most recently from 302721f to 54a0bc0 Compare February 3, 2026 09:11
@gingerbenw
gingerbenw force-pushed the gingerbenw/fixup-network-request-scenario branch from 54a0bc0 to 1f587bc Compare February 3, 2026 16:15
@gingerbenw
gingerbenw force-pushed the gingerbenw/fixup-network-request-scenario branch 6 times, most recently from d81ba3f to 58db5cb Compare February 4, 2026 14:26
@gingerbenw
gingerbenw force-pushed the gingerbenw/fixup-network-request-scenario branch from 58db5cb to a6dacec Compare February 4, 2026 14:46
@gingerbenw
gingerbenw requested a review from Copilot February 4, 2026 15:54

This comment was marked as resolved.

Sign in to view

@gingerbenw gingerbenw changed the title Manually construct fetch url in react native test fixture Manually parse fetch urls Feb 4, 2026
@gingerbenw
gingerbenw marked this pull request as ready for review February 4, 2026 16:06
@gingerbenw
gingerbenw requested a review from lemnik February 4, 2026 16:06
@gingerbenw gingerbenw changed the title Manually parse fetch urls Manually parse urls Feb 4, 2026
@gingerbenw
gingerbenw merged commit fdba07e into next Feb 5, 2026
103 checks passed
@gingerbenw
gingerbenw deleted the gingerbenw/fixup-network-request-scenario branch February 5, 2026 11:11
gingerbenw added a commit that referenced this pull request Feb 5, 2026
@gingerbenw @dependabot
Merge latest changes from next (#2675)
567e92e 
* build(deps): bump actions/checkout from 6.0.1 to 6.0.2 (#2672)

Bumps [actions/checkout](https://github.com/actions/checkout) from 6.0.1 to 6.0.2.
- [Release notes](https://github.com/actions/checkout/releases)
- [Changelog](https://github.com/actions/checkout/blob/main/CHANGELOG.md)
- [Commits](actions/checkout@8e8c483...de0fac2)

---
updated-dependencies:
- dependency-name: actions/checkout
  dependency-version: 6.0.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Manually parse urls (#2674)

* test: ✅ fix react native test, removing need for polyfill

* refactor: ♻️ update query parameter parsing

* remove use of url.search

* remove URLSearchParams

* Find the earliest occurrence of '/', '?', or '#' to determine the domain boundary

* docs: add CHANGELOG entry

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@SB-priyankap SB-priyankap mentioned this pull request Apr 7, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Lite
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
+1 more reviewer
@lemnik lemnik lemnik approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@gingerbenw @lemnik