refactor: ♻️ update query parameter parsing

Author: gingerbenw

packages/node/test/notifier.test.ts

@@ -4,6 +4,7 @@ describe('node notifier', () => {
   beforeAll(() => {
     jest.spyOn(console, 'debug').mockImplementation(() => {})
     jest.spyOn(console, 'warn').mockImplementation(() => {})
+    jest.spyOn(console, 'log').mockImplementation(() => {})
   })
 
   beforeEach(() => {

packages/plugin-aws-lambda/test/serverless-express.test.js

@@ -14,6 +14,10 @@ let sentEvents
 let sentSessions
 
 describe('serverless express', function () {
+  beforeAll(() => {
+    jest.spyOn(console, 'debug').mockImplementation(() => {})
+  })
+
   beforeEach(function () {
     sentEvents = []
     sentSessions = []

packages/plugin-network-instrumentation/lib/redact-query-parameters.js

@@ -16,7 +16,7 @@ module.exports = function (url, redactedKeys) {
 
   // Parse the URL - use a base only for relative URLs
   const urlObj = new URL(url, base)
-  const params = new URLSearchParams(urlObj.search)
+  const params = urlObj.search ? new URLSearchParams(urlObj.search) : new URLSearchParams()
 
   // Convert URLSearchParams to object without using Object.fromEntries()
   const paramsObject = {}
@@ -25,14 +25,16 @@ module.exports = function (url, redactedKeys) {
   })
 
   const redactedParams = redactValues(paramsObject, redactedKeys)
-  urlObj.search = new URLSearchParams(redactedParams).toString()
+  if (urlObj.search) {
+    urlObj.search = new URLSearchParams(redactedParams).toString()
+  }
 
   // Return appropriate format based on original URL type
   if (isAbsolute) {
     return decodeURI(urlObj.toString())
   }
 
   // For relative URLs, return only the path + search + hash components
-  const relativePart = urlObj.pathname + urlObj.search + urlObj.hash
+  const relativePart = urlObj.pathname + (urlObj.search || '') + urlObj.hash
   return decodeURI(relativePart)
 }

test/browser/features/http_errors.feature

@@ -16,7 +16,7 @@ Feature: HTTP Errors
     And the exception "errorClass" equals "HTTPError"
     And the error payload field "events.0.exceptions.0.message" equals the stored value "expected.exception.message"
     And the event "severity" equals "error"
-    And the event "unhandled" is true
+    And the event "unhandled" is false
     And the event "severityReason.type" equals "httpError"
     And the error payload field "events.0.context" equals the stored value "expected.context"
 
@@ -46,7 +46,7 @@ Feature: HTTP Errors
     And the exception "errorClass" equals "HTTPError"
     And the error payload field "events.0.exceptions.0.message" equals the stored value "expected.exception.message"
     And the event "severity" equals "error"
-    And the event "unhandled" is true
+    And the event "unhandled" is false
     And the event "severityReason.type" equals "httpError"
     And the error payload field "events.0.context" equals the stored value "expected.context"
 
@@ -78,7 +78,7 @@ Feature: HTTP Errors
     And the exception "errorClass" equals "HTTPError"
     And the error payload field "events.0.exceptions.0.message" equals the stored value "expected.exception.message"
     And the event "severity" equals "error"
-    And the event "unhandled" is true
+    And the event "unhandled" is false
     And the event "severityReason.type" equals "httpError"
     And the error payload field "events.0.context" equals the stored value "expected.context"
 
@@ -109,7 +109,7 @@ Feature: HTTP Errors
     And the exception "errorClass" equals "HTTPError"
     And the error payload field "events.0.exceptions.0.message" equals the stored value "expected.exception.message"
     And the event "severity" equals "error"
-    And the event "unhandled" is true
+    And the event "unhandled" is false
     And the event "severityReason.type" equals "httpError"
     And the error payload field "events.0.context" equals the stored value "expected.context"