Skip to content

Mark HTTP errors as handled instead of unhandled#2662

Merged
gingerbenw merged 5 commits intonextfrom
test/react-native-http-errors
Feb 2, 2026
Merged

Mark HTTP errors as handled instead of unhandled#2662
gingerbenw merged 5 commits intonextfrom
test/react-native-http-errors

Conversation

@gingerbenw
Copy link
Copy Markdown
Contributor

@gingerbenw gingerbenw commented Jan 23, 2026

Goal

This PR adds comprehensive test coverage for network-related functionality in React Native, including both network breadcrumbs and HTTP error reporting. The changes also fix an issue where HTTP errors were incorrectly marked as unhandled.

Changeset

  • Update plugin-network-instrumentation to mark HTTP errors as handled instead of unhandled

Testing

  • Add test scenarios for network breadcrumbs and HTTP error handling in React Native
  • Add supporting test fixtures and configuration for new test scenarios

@gingerbenw gingerbenw force-pushed the test/react-native-http-errors branch from 03439e1 to ec1f316 Compare January 23, 2026 16:40
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jan 23, 2026

@bugsnag/browser bundle size diff

Minified Minfied + Gzipped
Before 50.69 kB 15.03 kB
After 50.69 kB 15.03 kB
± No change No change

code coverage diff

<temporarily disabled>

Generated by 🚫 dangerJS against 1dcb65d

@gingerbenw gingerbenw force-pushed the test/react-native-http-errors branch 22 times, most recently from 38bb89e to 4bf97f0 Compare January 29, 2026 14:45
@gingerbenw gingerbenw force-pushed the test/react-native-http-errors branch 2 times, most recently from a10adb8 to 5a54e44 Compare January 29, 2026 16:28
@gingerbenw gingerbenw force-pushed the test/react-native-http-errors branch from 5a54e44 to cbb99ff Compare January 29, 2026 17:06
@gingerbenw gingerbenw requested a review from Copilot January 29, 2026 17:06

This comment was marked as resolved.

@gingerbenw gingerbenw changed the title test: 🧪 add network breadcrumb test to react native Mark HTTP errors as handled instead of unhandled Jan 29, 2026
@gingerbenw gingerbenw marked this pull request as ready for review January 29, 2026 17:32
@gingerbenw gingerbenw requested a review from a team January 29, 2026 17:32
hamudi-ahmed
hamudi-ahmed previously approved these changes Jan 30, 2026
@gingerbenw gingerbenw enabled auto-merge January 30, 2026 17:46
@gingerbenw gingerbenw requested a review from lemnik January 30, 2026 17:46
@gingerbenw gingerbenw disabled auto-merge February 2, 2026 10:20
@gingerbenw gingerbenw merged commit 6e367ad into next Feb 2, 2026
22 checks passed
@gingerbenw gingerbenw deleted the test/react-native-http-errors branch February 2, 2026 10:21
SB-priyankap pushed a commit that referenced this pull request Mar 11, 2026
Mark HTTP errors as handled instead of unhandled
@SB-priyankap SB-priyankap mentioned this pull request Apr 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants