Merge pull request #2662 from bugsnag/test/react-native-http-errors

Mark HTTP errors as handled instead of unhandled

Author: gingerbenw

CHANGELOG.md

@@ -6,6 +6,10 @@
 
 Update bugsnag-android to [v6.22.0](https//github.com/bugsnag/bugsnag-android/releases/tag/v6.22.0) [#2656](https://github.com/bugsnag/bugsnag-js/pull/2656)
 
+### Fixed
+
+(plugin-network-instrumentation) Report HTTP Errors as handled [#2662](https://github.com/bugsnag/bugsnag-js/pull/2662)
+
 ## [8.8.1] - 2026-01-26
 
 ### Fixed

packages/plugin-network-instrumentation/network-instrumentation.js

@@ -136,7 +136,7 @@ module.exports = (config = {}, global = window) => {
 
           const handledState = {
             severity: 'error',
-            unhandled: true,
+            unhandled: false,
             severityReason: { type: 'httpError' }
           }
 

packages/plugin-network-instrumentation/test/network-instrumentation-xhr.test.ts

@@ -135,7 +135,7 @@ describe('plugin-network-instrumentation', () => {
       expect(event.exceptions[0].errorMessage).toBe('404: https://api.example.com/users/123')
       expect(event.context).toBe('POST api.example.com')
       expect(event.severity).toBe('error')
-      expect(event.unhandled).toBe(true)
+      expect(event.unhandled).toBe(false)
       expect(event.severityReason.type).toBe('httpError')
 
       // Verify request metadata

packages/plugin-network-instrumentation/test/network-instrumentation.test.ts

@@ -87,7 +87,7 @@ describe('plugin-network-instrumentation', () => {
       expect(event.exceptions[0].errorMessage).toBe('404: https://example.com/api/users')
       expect(event.context).toBe('GET example.com')
       expect(event.severity).toBe('error')
-      expect(event.unhandled).toBe(true)
+      expect(event.unhandled).toBe(false)
       expect(event.severityReason.type).toBe('httpError')
       expect(event.request.url).toBe('https://example.com/api/users')
       expect(event.request.httpMethod).toBe('GET')

scripts/generate-react-native-fixture.js

@@ -40,7 +40,8 @@ const replacementFilesDir = resolve(ROOT_DIR, 'test/react-native/features/fixtur
 
 const INTERNAL_DEPENDENCIES = [
   '@bugsnag/react-native',
-  '@bugsnag/request-tracker'
+  '@bugsnag/request-tracker',
+  '@bugsnag/plugin-network-instrumentation'
 ]
 
 // make sure we install a compatible versions of peer dependencies

test/react-native/features/breadcrumbs.feature

@@ -47,3 +47,10 @@ Scenario: Manual breadcrumbs (Native)
   | ios     | NSException                |
   And the exception "message" equals "BreadcrumbsNativeManualScenario"
   And the event contains a breadcrumb matching the JSON fixture in "features/fixtures/expected_breadcrumbs/NativeManualScenario.json"
+
+Scenario: Network breadcrumbs (JS)
+  When I run "NetworkBreadcrumbsJsScenario"
+  Then I wait to receive an error
+  And the exception "errorClass" equals "Error"
+  And the exception "message" equals "NetworkBreadcrumbsJsScenario"
+  And the event contains a breadcrumb matching the JSON fixture in "features/fixtures/expected_breadcrumbs/NetworkJsScenario.json"

test/react-native/features/fixtures/expected_breadcrumbs/NetworkJsScenario.json

@@ -0,0 +1,11 @@
+{
+    "type": "request",
+    "name": "XMLHttpRequest succeeded",
+    "timestamp": "^\\d{4}\\-\\d{2}\\-\\d{2}T\\d{2}:\\d{2}:[\\d\\.]+Z?$",
+    "metaData": {
+        "status": "NUMBER",
+        "method": "GET",
+        "url": "^http:\/\/[0-9.:]*\/reflect$",
+        "duration": "NUMBER"
+    }
+}

test/react-native/features/fixtures/expected_http_errors/401.json

@@ -0,0 +1,8 @@
+[
+  {
+    "message": "^401: .*\/reflect\/[?]status=401$",
+    "errorClass": "HTTPError",
+    "type": "reactnativejs",
+    "stacktrace": "IGNORE"
+  }
+]

test/react-native/features/fixtures/expected_http_errors/500.json

@@ -0,0 +1,8 @@
+[
+  {
+    "message": "^500: .*\/reflect\/[?]status=500$",
+    "errorClass": "HTTPError",
+    "type": "reactnativejs",
+    "stacktrace": "IGNORE"
+  }
+]

test/react-native/features/fixtures/scenario-launcher/scenarios/core/NetworkBreadcrumbsJsScenario.js

@@ -0,0 +1,15 @@
+import Scenario from './Scenario'
+import Bugsnag from '@bugsnag/react-native'
+
+export class NetworkBreadcrumbsJsScenario extends Scenario {
+  constructor (nativeConfig, jsConfig, scenarioData) {
+    super()
+    this.reflectEndpoint = nativeConfig.endpoints.notify.replace('/notify', '/reflect')
+  }
+
+  run () {
+    fetch(this.reflectEndpoint).then(() => {
+      Bugsnag.notify(new Error('NetworkBreadcrumbsJsScenario'))
+    })
+  }
+}